What version of hpricot is necessary for running tests?

0 views
Skip to first unread message

Joe Van Dyk

unread,
Nov 8, 2009, 12:17:28 AM11/8/09
to Haml
I seemed to have the most success with hpricot version 0.6. Using
hpricot 0.8 made a lot of tests fail.

On a side note, why aren't we using nokogiri?

Nathan Weizenbaum

unread,
Nov 8, 2009, 12:27:46 AM11/8/09
to ha...@googlegroups.com
I'm using hpricot 0.8, and everything's working for me...

as to why not Nokogiri, mostly because it's already written in Hpricot and I don't know the Nokogiri APIs. If you want to take a crack at rewriting, go for it.

Chris Eppstein

unread,
Nov 8, 2009, 1:14:17 AM11/8/09
to ha...@googlegroups.com
I just finished porting our app from Hpricot to Nokogiri... I took notes and plan to write a blog post soon.

-chris

Nathan Weizenbaum

unread,
Nov 8, 2009, 7:42:23 PM11/8/09
to ha...@googlegroups.com
Apparently Hpricot 0.8.2 breaks a lot of stuff... I've pushed compatibility fixes to stable and master. They'll be released as part of 2.2.13, probably some time today or tomorrow.

Mislav Marohnić

unread,
Nov 9, 2009, 4:51:57 AM11/9/09
to ha...@googlegroups.com
On Sun, Nov 8, 2009 at 06:27, Nathan Weizenbaum <nex...@gmail.com> wrote:

as to why not Nokogiri, mostly because it's already written in Hpricot and I don't know the Nokogiri APIs

Why port to Nokogiri? We are not using any of its extra features, nor we need speed. Hpricot is a great parser and I've seen it resolve a messy HTML document with loads of SCRIPT tags much better than Nokogiri.

If it isn't broken, don't change it. And if the code is incompatible with new Hpricot, just load the old one (v0.6.x) via the `gem` function.
Reply all
Reply to author
Forward
0 new messages