Haml 2.0.8 Released

[Nathan Weizenbaum]

Hi folks,

I just released Haml 2.0.8. It's a minor bugfix release, including fixes for various Rails and 1.9.1 compatibility issues.

- Nathan

[Wincent Colaiuta]

Output of "git log 2.0.7..2.0.8":

commit 4f1f55c5288424093c8fcbee30d279fe243f1226
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Fri Feb 13 11:41:35 2009 -0800

Update VERSION for 2.0.8.

commit 511b173fe280fb2f4677fba7ca0bb558e05f0476
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Fri Feb 13 11:40:52 2009 -0800

Fix haml --version revision reporting.

commit 74d8a562785c0fcc6c09db28ee22cb42ee574e49
Author: Chris Eppstein <ch...@eppsteins.net>
Date: Tue Feb 10 01:39:18 2009 -0800

Test haml & sass against multiple versions of rails.

commit 03f1d9a57bc10ac43801d1cc3bb6b422cdd50ecf
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Mon Feb 9 11:18:33 2009 -0800

Fix tests to work with Rails 2.3.0.

commit 42c3612c09daa5c8318ff696f68880eee0eb7c2c
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Sat Feb 7 19:46:31 2009 -0800

[Haml] Fix another 1.9 test failure.

commit a0dda5f1eac160779043f63154152d9444a6b833
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Sat Feb 7 13:26:46 2009 -0800

[Sass] 1.9.1 compatibility.

commit f7a05f7e7dc11c8efd57270df36caa6018b3ea21
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Sat Feb 7 02:33:58 2009 -0800

[Haml] Fix a bunch of 1.9.1 compatibility issues.

There's still one test failure that only appears for me when I run
all the tests
and doesn't have a meaningful backtrace.

commit 23848a2ce438715d1ca8d3e48799178531848231
Author: Chris Eppstein <ch...@eppsteins.net>
Date: Sun Jan 25 11:02:33 2009 -0800

Change the versioning approach to use a module so it can be
accessed from Haml.version or Sass.version.
This makes Sass version checks more light-weight and allows for
divergence in the future.

commit 3f13355c408d661508e746c07dad1b11fd80683b
Author: Nathan Weizenbaum <nex...@gmail.com>
Date: Fri Jan 23 08:19:44 2009 -0800

Add extra/* to gemspec.

[Wincent Colaiuta]

One minor glitch I discovered since updating from 2.0.6 to 2.0.8
(actually looks like the problem started in 2.0.7); now I get this in
the console whenever I start the server or run "script/console":

vendor/gems/haml-2.0.8/lib/haml/util.rb:5: warning: already
initialized constant RUBY_VERSION

This with Haml vendored into "vendor/gems" in an app running Rails
2.3.0 RC1; haven't tested it against other versions of Rails. Looks
like the problem was introduced in Haml commit 8e1b40e, "Compatibility
with 1.9 *_methods methods which return symbols".

Cheers,
Wincent

[Nathan Weizenbaum]

That would come from requiring haml/util twice, which really shouldn't be happening... what's the backtrace? Could you also add "raise 'foo'" to the top of lib/haml/util.rb and see what the backtrace is for the first time it's included?

[Wincent Colaiuta]

On 14 feb, 20:42, Nathan Weizenbaum <nex...@gmail.com> wrote:
> That would come from requiring haml/util twice, which really shouldn't be
> happening... what's the backtrace? Could you also add "raise 'foo'" to the
> top of lib/haml/util.rb and see what the backtrace is for the first time
> it's included?

Unfortunately Rails/Mongrel (don't know which) drops almost the entire
backtrace on the floor so you can't see most of it:

http://pastie.org/389623.txt

So I stuck this in lib/haml/util.rb instead:

if $foobar.nil?
$foobar = 0
begin
raise "Time #{$foobar}:"
rescue Exception => e
puts e.message
e.backtrace.each { |f| puts " #{f}" }
end
else
$foobar += 1
begin
raise "Time #{$foobar}:"
rescue Exception => e
puts e.message
e.backtrace.each { |f| puts " #{f}" }
end
end

Here's the result:

http://pastie.org/389625.txt

Most of the backtraces are inside "vendor", so I'll just clarify what
the non-vendor parts are:

Line 10 of config/environment.rb refers to this line:

Rails::Initializer.run do |config|

And line 16 of config/environments/development.rb refers to this line:

Sass::Plugin.options[:always_update] = true

So that's the first time through...

And in the second time through, we again hit line 10 of config/
environment.rb, but that's all. No other non-"vendor" frames in the
traces.

Cheers,
Wincent

[Nathan Weizenbaum]

Okay, looks like the problem is just that haml/util wasn't required by Sass. It should be fixed now in the latest stable and master.

[Wincent Colaiuta]

On 15 feb, 10:24, Nathan Weizenbaum <nex...@gmail.com> wrote:
> Okay, looks like the problem is just that haml/util wasn't required by Sass.
> It should be fixed now in the latest stable and master.

Ok, I applied the fix here locally as well and I can verify that it
fixes the issue.

Thanks,
Wincent