How to contribute?

26 views
Skip to first unread message

Alan Escreet

unread,
Feb 21, 2012, 3:09:57 AM2/21/12
to Hamcrest Developers
I'd like to contribute, but I haven't found any information how to do
so.

SVN access is read-only and I haven't found a way to submit a pull
request (like on github).
Do you have a process for submissions or for contributor applications?

Steve Freeman

unread,
Feb 21, 2012, 4:30:26 AM2/21/12
to hamcre...@googlegroups.com
The old-fashioned way by submitting a patch, possibly attached to an issue.

Perhaps it is time to move on from svn.

S.

> --
> You received this message because you are subscribed to the Google Groups "Hamcrest Developers" group.
> To post to this group, send email to hamcre...@googlegroups.com.
> To unsubscribe from this group, send email to hamcrest-dev...@googlegroups.com.
> For more options, visit this group at https://console.mxlogic.com/redir/?IKfIELFL6Sn7XzDTS3o0cz6HqRe8RGhf_BY8NGSJxflrh-AOW7CihcYXU6XYDuZXTLuZPtPpflrh-AOW7Cg0A8mIv5Wlp6ip10PmHbx0xnNkIj7fq2ydqAj_8NGSJjBPr3UVASyOCqenAkTXL6QnzonGod44WCy2Rojz8wTfOhKvxYYmfSk3q9J4SOU_ss---rWQE2.
>

Steve Freeman

Winner of the Agile Alliance Gordon Pask award 2006
Book: http://www.growing-object-oriented-software.com

+44 797 179 4105
Twitter: @sf105
Higher Order Logic Limited
Registered office. 2 Church Street, Burnham, Bucks, SL1 7HZ.
Company registered in England & Wales. Number 7522677

David Harkness

unread,
Feb 25, 2012, 4:49:23 AM2/25/12
to hamcre...@googlegroups.com
I would definitely support switching from Google Code to Github. IIRC both the Objective-C and Python ports are being built in Github and sync'd to GC. Using Github would also give us a chance to split up each port under a separate repository under a single Hamcrest umbrella I think. Of course the biggest improvement would be the easier method of suggesting patches with code reviews.

Peace,
David

Chris Rose

unread,
Feb 25, 2012, 12:22:06 PM2/25/12
to Hamcrest Developers
I'm one of the contributors to the Python end of the project, and I
have to agree; the contribution model of Github is far easier to work
with than the model that google code offers.

Now, it's notable that GC offers Mercurial access as well, and I've
had some success with that on other projects -- mock, tox, py, et al
-- but the Mercurial interface does not lend itself well to
collaboration in the same way that github's meta-language of pull
requests does.

I think that creating a Hamcrest org on github and moving each
implementation into there as the "blessed" primary repository would be
an excellent idea, and I'm more than willing to manage updating the
PyPi entries for Hamcrest, as well as bringing the documentation into
sync.

Chris Rose

unread,
Apr 1, 2012, 2:12:56 AM4/1/12
to Hamcrest Developers
No movement has happened on this front, as far as I can see. I'm
willing to take the lead and create the organization, and move the
python implementation into it. I'd expect the leads for other
languages to do the same, ideally fairly speedily.

Is that desirable?

Joe Walnes

unread,
Apr 1, 2012, 8:20:47 AM4/1/12
to hamcre...@googlegroups.com
Although I can offer no time to help, I'm in support of this plan. I think it will help the project health.

Do any of the core Hamcrest devs have opinions on this?

--
You received this message because you are subscribed to the Google Groups "Hamcrest Developers" group.
To post to this group, send email to hamcre...@googlegroups.com.
To unsubscribe from this group, send email to hamcrest-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/hamcrest-dev?hl=en.


Steve Freeman

unread,
Apr 1, 2012, 9:11:54 AM4/1/12
to hamcre...@googlegroups.com
I've made a couple of abortive attempts to export the java version to git. Are people transferring the history across or just the last cut?

I think it would also be good to have each language in its own repository, with some cross-linking, rather than in a single repo.

S.

Chris Rose

unread,
Apr 1, 2012, 11:49:32 AM4/1/12
to hamcre...@googlegroups.com
I imagine that it should be fairly easy to import from SVN. git-svn clone should do the trick, if nothing else, but github has good documentation here: http://help.github.com/import-from-subversion/

I'll give this thread a couple of days -- it being the weekend -- to get developers' attention, and then I'll set up the organization. I'm going to create it today, though, and plan the transition of the python implementation in to it.

If I could get the github account names of the project owners (ideally, 1 or 2 per language) to add as organization owners, that would be optimal.

--
You received this message because you are subscribed to the Google Groups "Hamcrest Developers" group.
To post to this group, send email to hamcre...@googlegroups.com.
To unsubscribe from this group, send email to hamcrest-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/hamcrest-dev?hl=en.




--
Chris R.
======
Not to be taken literally, internally, or seriously.
Twitter: http://twitter.com/offby1

Chris Rose

unread,
Apr 1, 2012, 11:53:23 AM4/1/12
to hamcre...@googlegroups.com
First hamcrest repository: https://github.com/hamcrest/PyHamcrest

Neil Dunn

unread,
Apr 1, 2012, 12:16:46 PM4/1/12
to hamcre...@googlegroups.com
I think this is a good idea.


Chris Rose

unread,
Apr 1, 2012, 12:36:51 PM4/1/12
to hamcre...@googlegroups.com
So, eyeballing the existing SVN repositories, I have a bad feeling about the maintenance of tags for the subprojects; the current repository does not have a standard layout, which will make importing the tags difficult.

I recommend the following:

For each project, use svn2git in trunk-only mode to import the trunk as a git repo.

Manually identify the revisions that are tags, and apply them using git tag

Push to hamcrest/<Language>Hamcrest

This entails a bit of manual work, but much of it's already done; only Java and PHP need to be manually massaged in this way -- Objective-C and Python are already on github primarily. PHP has one tag, and Java has 9 tags. Hardly an epic effort.

Steve Freeman

unread,
Apr 1, 2012, 4:51:09 PM4/1/12
to hamcre...@googlegroups.com
First cut import https://github.com/sf105/JavaHamcrest

I'll move it to the hamcrest organisation when I get access.

S.

David Harkness

unread,
Apr 2, 2012, 4:52:10 AM4/2/12
to hamcre...@googlegroups.com
Thanks for getting this started. I'll take care of the PHP port when I
get a chance. My Github account is "dharkness".
Reply all
Reply to author
Forward
0 new messages