On 8/20/2012 5:53 PM, Guido Erlinger wrote:
> According to the wiki one theme.xml should be enough to start a child theme.
> But all the formatting is gone (wrong path to styles.css) and some notes
> (undefined variables, invalid argument) are output.
> Is the Charcoal theme ready for child themes?
Charcoal, I suspect, is not ready and will likely never be ready to be
made into a parent theme -- It's a long-standing theme from early in
Habari, and it just hasn't been retrofitted with the things that make
parent/child themes easy.
Wazi, on the other hand, is good to use as a parent theme, and I am
doing so on my own site.
The key thing is that Wazi's CSS files are added via its theme class.
If you provide no theme class in your child theme, then the default
Theme class is used, and no styles are added. If you want Wazi to add
its CSS to the output stack, you must also include (in addition to the
theme.xml) a barebones class file, which extends Wazi's class:
class MyChildTheme extends WaziTheme {}
Then you can add css and javascript files to your child theme's assets
directory, and Habari will automatically add them to the appropriate
stacks for output, in addition to the ones from Wazi.
If you want your child class to have methods (to change post formatting
or add other features), then you will need to extend WaziTheme and call
any parent methods or the methods that Wazi provides that are useful for
output (action_template_header) will not be called. On the other hand,
if you want to override what Wazi does in action_template_header
entirely, you should implement that method and not call
parent::action_template_header(). These are basic OOP principles that
folks will recognize.
Finally, I just pushed a change to 0.10 that eliminates the need to
include this vestigial theme file and class at all, allowing you to
specify only the xml and an asset directory.
Owen
