[patch] more http 404 handling

0 views
Skip to first unread message

Paul Querna

unread,
Nov 6, 2008, 1:37:43 AM11/6/08
to habar...@googlegroups.com
I noticed a small problem in the HTTP status handling.

For example:
http://demo.habariproject.org/3rdparty/blueprint/do-a-404-kthanks

Sends HTTP 200.

When I was going to fix it, I also noticed that I had trouble with 404s in general, when I use FastCGI as my PHP SAPI, so I added a Utils::http_status that wraps the header() calls to make it portable between the different SAPIs.

(not religious about the method name, what should it be?)

Attached is the patch so far.

Tested to work on my FastCGI PHP/mod_fcgid setup on FreeBSD.

Thanks,

Paul

http-status.patch

Chris J. Davis

unread,
Nov 6, 2008, 7:49:55 AM11/6/08
to habar...@googlegroups.com
Looks good to me, we need some people to apply the patch and vet it. It applied cleanly for me, and seems to be working properly.

Who else can test this?

chris

<http-status.patch>

Reply all
Reply to author
Forward
0 new messages