Re: [Habari-SVN] [habari commit] r1030 - branches/skeletor/system/admin

1 view
Skip to first unread message

Robin Adrianse

unread,
Oct 21, 2007, 5:57:31 PM10/21/07
to habar...@googlegroups.com
What about a <dl /> list?

On 10/21/07, codesite...@google.com < codesite...@google.com> wrote:

Author: miklb.online
Date: Sun Oct 21 14:36:38 2007
New Revision: 1030

Modified:
   branches/skeletor/system/admin/moderate.php

Log:
fixing comment count format, switched to table

Modified: branches/skeletor/system/admin/moderate.php
==============================================================================
--- branches/skeletor/system/admin/moderate.php (original)
+++ branches/skeletor/system/admin/moderate.php Sun Oct 21 14:36:38 2007
@@ -2,7 +2,7 @@

<div class="container">
        <hr>
-       <div class="column span-24 last">
+       <div class="column span-24">
                <?php
                if ( isset( $result ) ) {
                        switch( $result ) {
@@ -15,13 +15,14 @@
                <h1><?php _e('Habari Comments'); ?></h1>
                <p><?php _e('Here you will find all the comments, including those
deleted. You can also manage the pingbacks.'); ?></p>

-               <div class="column span-7 first" id="stats">
+               <div class="column span-7 first">
                        <h3><?php _e('Comment Statistics'); ?></h3>
-                       <ul>
-                               <li><span class="right"><?php echo Comments::count_total(
Comment::STATUS_APPROVED ); ?></span><?php _e('Total Approved Comments'); ?></li>
-                               <li><span class="right"><?php echo Comments::count_total(
Comment::STATUS_UNAPPROVED ); ?></span><?php _e('Total Unapproved Comments'); ?></li>
-                               <li><span class="right"><?php echo Comments::count_total(
Comment::STATUS_SPAM ); ?></span><?php _e('Total Spam Comments'); ?></li>
-                       </ul>
+                       <table width="100%" cellspacing="0">
+
+                               <tr><td><?php _e('Total Approved Comments'); ?></td><td><?php echo
Comments::count_total( Comment::STATUS_APPROVED ); ?></td></tr>
+                               <tr><td><?php _e('Total Unapproved Comments'); ?></td><td><?php
echo Comments::count_total( Comment::STATUS_UNAPPROVED ); ?></td></tr>
+                               <tr><td><?php _e('Total Spam Comments'); ?></td><td><?php echo
Comments::count_total( Comment::STATUS_SPAM ); ?></td></tr>
+                       </table>
                </div>

                <div class="column span-17 last push-1">

Michael Bishop

unread,
Oct 21, 2007, 7:44:22 PM10/21/07
to habari-dev
Truthfully, this was meant for trunk, and a temporary fix for the
stats, until admin gets redone. The original float right on the count
was offsetting by 18pixels, basically putting the count a line below
the rest of the <li>. With the old admin.css and the blueprint css, I
felt using a table at this point was the most solid solution, vs using
a negative margin on the span, or trying to troubleshoot the css that
will hopefully sooner than later be changed anyway.

~milkb


On Oct 21, 5:57 pm, "Robin Adrianse" <robin....@gmail.com> wrote:
> What about a <dl /> list?
>

> On 10/21/07, codesite-nore...@google.com <codesite-nore...@google.com>

Reply all
Reply to author
Forward
0 new messages