Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
gyp-developer
Home
+ new post
About this group
Join this group
Message from discussion Parallelize ninja generation when GYP_PARALLEL=1. (issue 11026061)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
tha...@chromium.org  
View profile  
 More options Oct 5 2012, 4:14 am
From: tha...@chromium.org
Date: Fri, 05 Oct 2012 08:14:09 +0000
Local: Fri, Oct 5 2012 4:14 am
Subject: Re: Parallelize ninja generation when GYP_PARALLEL=1. (issue 11026061)
Print | View thread | Show original | Report this message | Find messages by this author
On 2012/10/05 07:14:17, Dominic Mazzoni wrote:

> On 2012/10/05 07:09:34, Nico wrote:
> > Ok.

> > Any reason to not just always do this, instead of having it behind a  
> flag?
> I didn't want to break everyone's build if there was a bug.

That'd justify putting every single change behind a flag. There'll probably  
be
no bug, and if there is, gyp rolls are easy to revert.

> Also, I think it shouldn't be the default for all configurations - like a
> single-processor machine, but also it's possible that for a heavily-loaded
> machine (like a build slave?) it could make things worse, not better.

Can you measure if that's the case? (Disable all but one core locally, run a
python shell with an endless loop.)

Just like in chrome ui, it's better to make these decisions yourself  
instead of
leaving the choice to the user who won't know how which option to pick.

(My guess is that it's fine to just disable it, but if it's not, you should  
gate
this on the number of processors or the load average, not on an option)

http://codereview.chromium.org/11026061/


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google