spaces in action names

13 views
Skip to first unread message

Evan Martin

unread,
Aug 5, 2010, 2:30:34 PM8/5/10
to gyp-de...@googlegroups.com
http://code.google.com/p/chromium/issues/detail?id=51288
is that we broke with a new version of GNU make.

It stems from an action that has a space in its name, found in Chrome
(chrome/common_constants.gypi):
'action_name': 'Make chrome_version.cc',

I can fix the Make generator to work around this, or we can disallow
spaces in action names.
What do you say? (I only hesitated to consider the latter when I sat
down to implement the former, and discovered the existing gyp tests
are careful to use underscores in action names.)

Mark Mentovai

unread,
Aug 5, 2010, 2:34:21 PM8/5/10
to gyp-de...@googlegroups.com
The only reason the action names exist as they do is to show up in
various UIs and be easily tied back to where they came from in
.gyp-land. Considering that they’re UI-visible, we rely on spaces
pretty heavily in Mac-land.

Mark

Reply all
Reply to author
Forward
0 new messages