Re: Android backend: add CONFIGURATION_NAME. (issue 11013023)
11 views
Skip to first unread message
bradn...@google.com
Oct 3, 2012, 1:21:42 PM10/3/12
to to...@chromium.org, bradn...@chromium.org, gyp-de...@googlegroups.com
LGTM
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py
File pylib/gyp/generator/android.py (right):
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41
pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME':
'NOT_USED_ON_ANDROID',
Is this actually getting referenced and emitted, or just needs to be
defined and is then discarded?
If the later, you might want to consider None instead, as then it'll
blow up on reference at gyp time instead of build time?
https://codereview.chromium.org/11013023/
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py
File pylib/gyp/generator/android.py (right):
https://codereview.chromium.org/11013023/diff/1/pylib/gyp/generator/android.py#newcode41
pylib/gyp/generator/android.py:41: 'CONFIGURATION_NAME':
'NOT_USED_ON_ANDROID',
Is this actually getting referenced and emitted, or just needs to be
defined and is then discarded?
If the later, you might want to consider None instead, as then it'll
blow up on reference at gyp time instead of build time?
https://codereview.chromium.org/11013023/
bradn...@google.com
Oct 4, 2012, 12:19:29 PM10/4/12
to to...@chromium.org, bradn...@chromium.org, gyp-de...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages