How to contribute - best practises
45 views
Skip to first unread message
Raphael André Bauer
May 10, 2012, 10:47:20 AM5/10/12
to gwt-pl...@googlegroups.com
Hi,
we (James and me) are currently working on an example showing
html5pushstate and routes in places using gwtp.
What we did now:
- pull the gwtplatform repo via hg.
- created a new branch.
- added a new example project in maven that shows how to use the stuff.
- some additional non breaking changes in gwtp core to add our changes
Interestingly I just noticed that I still have write acces to the gwtp
repository (I think I contributed to the very early versions a loooong
time ago ;) )...
But - what would be the best way to show you the changes?
Simply push the branch?
Just let us know :)
Cheers...
Raphael
we (James and me) are currently working on an example showing
html5pushstate and routes in places using gwtp.
What we did now:
- pull the gwtplatform repo via hg.
- created a new branch.
- added a new example project in maven that shows how to use the stuff.
- some additional non breaking changes in gwtp core to add our changes
Interestingly I just noticed that I still have write acces to the gwtp
repository (I think I contributed to the very early versions a loooong
time ago ;) )...
But - what would be the best way to show you the changes?
Simply push the branch?
Just let us know :)
Cheers...
Raphael
Christian Goudreau
May 12, 2012, 9:22:04 PM5/12/12
to gwt-pl...@googlegroups.com
You could push the branch, than use codereview.appspot.com to let us review to code. Once every one agrees, you'll be able to merge right into master which will then get automatically compiled and push to maven using our CI.
This is a good news, because Monday we were going to start working on your contribution and include them, but it's even better if you contribute it yourself!
Thanks again!
Raphael André Bauer
May 14, 2012, 4:06:34 AM5/14/12
to gwt-pl...@googlegroups.com
On Sun, May 13, 2012 at 3:22 AM, Christian Goudreau
<goudreau....@gmail.com> wrote:
> You could push the branch, than use codereview.appspot.com to let us review
> to code. Once every one agrees, you'll be able to merge right into master
> which will then get automatically compiled and push to maven using our CI.
>
> This is a good news, because Monday we were going to start working on your
> contribution and include them, but it's even better if you contribute it
> yourself!
>
> Thanks again!
No - thank you :)
<goudreau....@gmail.com> wrote:
> You could push the branch, than use codereview.appspot.com to let us review
> to code. Once every one agrees, you'll be able to merge right into master
> which will then get automatically compiled and push to maven using our CI.
>
> This is a good news, because Monday we were going to start working on your
> contribution and include them, but it's even better if you contribute it
> yourself!
>
> Thanks again!
Ok - I'll do that today..
Cheers,
Raphael
>
> On Thu, May 10, 2012 at 10:47 AM, Raphael André Bauer
> <raphael.a...@gmail.com> wrote:
>>
>> Hi,
>>
>>
>> we (James and me) are currently working on an example showing
>> html5pushstate and routes in places using gwtp.
>>
>> What we did now:
>> - pull the gwtplatform repo via hg.
>> - created a new branch.
>> - added a new example project in maven that shows how to use the stuff.
>> - some additional non breaking changes in gwtp core to add our changes
>>
>> Interestingly I just noticed that I still have write acces to the gwtp
>> repository (I think I contributed to the very early versions a loooong
>> time ago ;) )...
>>
>> But - what would be the best way to show you the changes?
>>
>> Simply push the branch?
>>
>> Just let us know :)
>>
>>
>> Cheers...
>> Raphael
>
>
>
>
> --
> Christian Goudreau
> www.arcbees.com
>
inc: http://ars-machina.raphaelbauer.com
tech: http://ars-codia.raphaelbauer.com
web: http://raphaelbauer.com
Raphael André Bauer
May 14, 2012, 8:36:50 AM5/14/12
to gwt-pl...@googlegroups.com
On Mon, May 14, 2012 at 10:06 AM, Raphael André Bauer
<raphael.a...@gmail.com> wrote:
> On Sun, May 13, 2012 at 3:22 AM, Christian Goudreau
> <goudreau....@gmail.com> wrote:
>> You could push the branch, than use codereview.appspot.com to let us review
>> to code. Once every one agrees, you'll be able to merge right into master
>> which will then get automatically compiled and push to maven using our CI.
>>
>> This is a good news, because Monday we were going to start working on your
>> contribution and include them, but it's even better if you contribute it
>> yourself!
>>
>> Thanks again!
> No - thank you :)
>
> Ok - I'll do that today..
Okay... first time I am using upload.py and codereview @ googlecode.
<raphael.a...@gmail.com> wrote:
> On Sun, May 13, 2012 at 3:22 AM, Christian Goudreau
> <goudreau....@gmail.com> wrote:
>> You could push the branch, than use codereview.appspot.com to let us review
>> to code. Once every one agrees, you'll be able to merge right into master
>> which will then get automatically compiled and push to maven using our CI.
>>
>> This is a good news, because Monday we were going to start working on your
>> contribution and include them, but it's even better if you contribute it
>> yourself!
>>
>> Thanks again!
> No - thank you :)
>
> Ok - I'll do that today..
So bear with me in case something is wrong...
The diff should be here:
http://codereview.appspot.com/6213044/
Some things to notice:
- There are now two examples showing usage of "routes" and "routes and
html5 pushstate". Both examples contain some documentation when you
run gwt:run
-- gwtp-routes
-- gwtp-routes-and-html5pushstate
- I did not yet copy the relevant core files into gwtp-core. They are
still in the examples.
-- ParameterizedParameterTokenFormatter.java
-- ParameterizedPlaceRequest.java
-- Html5PushStatePlaceManager.java
Therefore I'd like to get some feedback if that makes sense and if you
got any ideas how to improve. I'd then copy the core files into gwtp
and resubmit :)
Thanks!
Best,
Raphael
Reply all
Reply to author
Forward
0 new messages