Branch that addresses a bunch of stuff

1 view
Skip to first unread message

Charlie Collins

unread,
Aug 15, 2008, 10:43:33 AM8/15/08
to gwt-maven
http://gwt-maven.googlecode.com/svn/branches/cc_20080814_automaticrefactor/

Instead of gwt-redux project I am now changing course a bit and
working in a branch of GWT-Maven. Many of the cleanups from gwt-redux
and in this branch, but I am not injecting all the GWT deps for all
phases based on the previous discussion and feedback (it was a bad
idea to go that way ;)).

At any rate, the branch works for my Linux tests thus far, and has a
lot of cleaned up stuff. Major points are:

1. No longer has setup and extract for automatic, instead uses
dependency plugin (see simplesample example in branch - this was done,
even though setup/extract was brilliant and is great, to reduce the
complexity and burden here, and achieve the same effect with standard
maven conventions)

2. Still supports concepts of "automatic" or "manual" mode. Automatic
uses dep plugin (as noted above) and central repo. Manual still uses
google.webtoolkit.home.

3. Uses the central repo for GWT deps - including native libs (with
classifiers, etc)

4. Injects gwt-dev and gwt-user for the run and compile scripts (only)
using a cleaned up utility class (along with a lot of other general
cleanup/refactor). Close to the same result as what we did before,
but much cleaner flow (IMO).

5. Many bug fixes are in the branch based on comments and patches in
the issue tracker. I commented on each issue in the tracker for those
that are in the branch, and made sure they are accepted - but didn't
close any yet.

6. Documentation has been updated and standardized too (uses plugin
plugin for goal info, for example). It's not published yet, but mvn
site demonstrates the new stuff.

7. I haven't tested the bean gen stuff. I don't use it, and I can't
get a hold of Cooper (who wrote it), haven't heard from him in
months. There are probably many bean gen issues, but I don't have
desire or time to get into it (there have been a lot of issues related
to it on the tracker for a long time too). If anyone here wants to
tackle that, let me know and I will add you to the project. If it
doesn't get much traction I might just remove that stuff (though it is
cool, it's not useful it its not maintained) and make it a separate
project (maybe should be a separate maven plugin for GWT anyway, that
would potentially be cleaner).

8. I don't know when it will make it to a release in the trunk, but
soon. I want to test more on mac (no difference with leopard in 1.5,
or not) and windows - and I want to test to make sure OLDER GWT
releases still work fine too.

As always, all feedback is welcome. Any contributions are welcome,
testers, documenters, coders, etc.

Mirko Nasato

unread,
Aug 19, 2008, 7:30:24 AM8/19/08
to gwt-...@googlegroups.com
I gave it a quick try and works fine for me.  I like the fact that a "manual" mode is still supported after all, if somebody already has the GWT distribution installed there's no point in downloading it again.

Will do some more testing over time.

2008/8/15 Charlie Collins <charlie...@gmail.com>

Charlie Collins

unread,
Aug 20, 2008, 6:04:54 AM8/20/08
to gwt-maven
I have been testing it a bit more to, so far so good.

I will try to make a release using this today, so that we can give it
some further testing (and others can help without having to build it,
hopefully), before I merge it into the trunk.

On Aug 19, 7:30 am, "Mirko Nasato" <mirko.nas...@gmail.com> wrote:
> I gave it a quick try and works fine for me.  I like the fact that a
> "manual" mode is still supported after all, if somebody already has the GWT
> distribution installed there's no point in downloading it again.
>
> Will do some more testing over time.
>
> 2008/8/15 Charlie Collins <charlie.coll...@gmail.com>
>
>
>
> >http://gwt-maven.googlecode.com/svn/branches/cc_20080814_automaticref...

Mirko Nasato

unread,
Aug 22, 2008, 12:41:03 PM8/22/08
to gwt-...@googlegroups.com
What about replacing all System.out.println() with mojo.getLog().debug()?

So debug logging is off by default and can turned on with the standard mvn -X switch.

Cheers

Mirko

2008/8/20 Charlie Collins <charlie...@gmail.com>

Sascha-Matthias Kulawik

unread,
Aug 22, 2008, 8:40:07 PM8/22/08
to gwt-...@googlegroups.com
Yes,

I think thats necessary.

Greetings,

Sascha

Charlie Collins

unread,
Aug 24, 2008, 7:32:51 AM8/24/08
to gwt-maven
I changed all the sys out stuff on Friday. It's all logging now.

That comes with one disclaimer though, the support jar still has some
sys outs, like the web inf processor and such, but the M2 plugin is
all loggigg now. At some point we will get the support jar cleaned up
too, but it's a bit more involved - whatever we do there has to work
with M1 also.

On Aug 22, 12:41 pm, "Mirko Nasato" <mirko.nas...@gmail.com> wrote:
> What about replacing all System.out.println() with mojo.getLog().debug()?
>
> So debug logging is off by default and can turned on with the standard mvn
> -X switch.
>
> Cheers
>
> Mirko
>
> 2008/8/20 Charlie Collins <charlie.coll...@gmail.com>
Reply all
Reply to author
Forward
0 new messages