Issue 223 in growl: hardwaregrowler crash on Lion

[gr...@googlecode.com]

Status: Accepted
Owner: rarich...@gmail.com
Labels: Type-Defect Priority-Medium OpSys-OSX

New issue 223 by rarich...@gmail.com: hardwaregrowler crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

airport related crash in hardwaregrowler, its a case where a foundation
object is not being nil checked prior to being passed to a CF function, the
result, as anyone who has written CF code before is that it will CRASH. The
original author's guard does not do what they think it does.

Attachments:
growlhardware+crash.rtf 34.3 KB

[gr...@googlecode.com]

Comment #1 on issue 223 by rarich...@gmail.com: hardwaregrowler crash on
Lion
http://code.google.com/p/growl/issues/detail?id=223

currently waiting from feedback from balrog in #growl about whether or not
the fix resolved the issue to his satisfaction.

[gr...@googlecode.com]

Comment #2 on issue 223 by still...@gmail.com: hardwaregrowler crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

I have a fix for this, as well as a lion build (x86 only, which is all that
lion runs on).

in HardwareGrowler/NetworkNotifier.m:

218c218,219
< AppController_airportConnect((CFStringRef)networkName,
CFDataGetBytePtr(newBSSID));
---
> if (newBSSID != NULL && networkName != NULL)
>
> AppController_airportConnect((CFStringRef)networkName,
> CFDataGetBytePtr(newBSSID));

[gr...@googlecode.com]

Comment #3 on issue 223 by lars.kap...@googlemail.com: hardwaregrowler

crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

Any chance for a compiled build soon? (This bug is really annoying :) )

[gr...@googlecode.com]

Comment #4 on issue 223 by lars.kap...@googlemail.com: hardwaregrowler

crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

I just recompiled it with the new line - works great. Thanks! :)

[gr...@googlecode.com]

Updates:
Status: FixedInSource

Comment #5 on issue 223 by rarich...@gmail.com: hardwaregrowler crash on
Lion
http://code.google.com/p/growl/issues/detail?id=223

fixed in dd896e6fbdce

[gr...@googlecode.com]

Comment #6 on issue 223 by MCT0...@gmail.com: hardwaregrowler crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

Any chance to share with us the compiled version with the new lines? Thank
you so much.

[gr...@googlecode.com]

Comment #7 on issue 223 by darryl.h...@gmail.com: hardwaregrowler crash on
Lion
http://code.google.com/p/growl/issues/detail?id=223

I apologize if this isn't the right forum to ask this question but, how do
I configure the Xcode project under Lion (Xcode 4.1)? I thought I'd
compile a fixed version of HardwareGrowler myself but was presented with so
many warnings and errors that I wasn't sure where to begin. I assume the
Xcode project file is still set up for Snow Leopard's version of Xcode?

[gr...@googlecode.com]

Comment #8 on issue 223 by p...@growl.info: hardwaregrowler crash on Lion
http://code.google.com/p/growl/issues/detail?id=223

@darryl.h (#7): Please ask that on the discussion group.
http://growl.info/contact.php

[Beau Giles]

I'd also love this... not most of all because I'm lazy. :-)