Out of curiosity, what was the issue with temp files? It was a little
awkward the way some of the tests were building the temp file
directory, but Java actually makes this pretty easy. E.g. see
Neo4jGraphSailTest:
On Thu, Jun 7, 2012 at 4:59 PM, Marko Rodriguez <okramma...@gmail.com> wrote:
> Yes. Stephen was saying that OrientGraphTest was acting weird on Windows.
> Can you have a looksy, please? .... Its pretty basic what I did, just
> changed the directory to use target/ instead of temp/.
On Thu, Jun 7, 2012 at 2:18 PM, Joshua Shinavier <j...@fortytwo.net> wrote:
> Out of curiosity, what was the issue with temp files? It was a little
> awkward the way some of the tests were building the temp file
> directory, but Java actually makes this pretty easy. E.g. see
> Neo4jGraphSailTest:
> On Thu, Jun 7, 2012 at 4:59 PM, Marko Rodriguez <okramma...@gmail.com> wrote:
>> Yes. Stephen was saying that OrientGraphTest was acting weird on Windows.
>> Can you have a looksy, please? .... Its pretty basic what I did, just
>> changed the directory to use target/ instead of temp/.
yes the cleanup by an annotated post (or sometimes pre, it depends) condition it's more clear.
Please consider that dir.delete() does not always return immediatly what we expected, especially on windows it sometimes has some delay, and this could introduce some weird result in the test
> On Thu, Jun 7, 2012 at 2:18 PM, Joshua Shinavier <j...@fortytwo.net> > wrote: > > Out of curiosity, what was the issue with temp files? It was a little > > awkward the way some of the tests were building the temp file > > directory, but Java actually makes this pretty easy. E.g. see > > Neo4jGraphSailTest:
> > On Thu, Jun 7, 2012 at 4:59 PM, Marko Rodriguez <okramma...@gmail.com> > wrote: > >> Yes. Stephen was saying that OrientGraphTest was acting weird on > Windows.
> >> Can you have a looksy, please? .... Its pretty basic what I did, just > >> changed the directory to use target/ instead of temp/.
> >>> And updated the JUnit tests in Blueprints so that target/test-data > holds > >>> the databases and database files. This way, no more C:/temp or /tmp.
