Ref: http://greasemonkey.devjavu.com/changeset/533
Cloned in: http://greasemonkey.devjavu.com/changeset/562

Aaron Boodman wrote:
> * Removed menu_ToolsSepFx from the insertBefore attribute from the firefox menu.
>I couldn't find this anywhere in the mozilla source, and it seems like javascriptConsole is a reasonable place for it. If this is wrong, we can add it back.

You are correct... it is not in the base Firefox code, but is actually dynamically created by Mozilla with the core distributions of Firefox.  If you personally wish to put it back in, it will keep the location consistent with previous versions. (e.g. backwards compatibility ;D ) but it not a requirement.

I put both in there, as if Firefox doesn't find the first one for some weird reason, it tries the next one, and if it doesn't find that one, it will append to the end of the menu.

>* Removed the duplicate attributes label and accesskey from the references to
>gm_general_menu, since things still seem to work with them only in the definition.

Works great on Linux Firefox... although I suggest removing the comment I put in now that you have removed the problem.
 (<!-- NOTE: Unlocalized accesskey & label in menu tags; possibly unaccessible --> ) in line 33.

I would test out the trunk build in SeaMonkey here, but I must be patient for you to add the missing contents.rdf in the locale too.

> * Removed position="10" from the definition of gm_general_menu; this seems to conflict with the insertBefore attribute
>
> * Added comments noting Firefox and Seamonkey specific elements

No qualms with these. Nice addition/subtractions. 8D

Marti wrote:

I would test out the trunk build in SeaMonkey here, but I must be patient for you to add the missing contents.rdf in the locale too.

For referencing sake:
http://greasemonkey.devjavu.com/browser/branches/mm1/src/chrome/chromeFiles/locale/en-US/contents.rdf?rev=525
http://greasemonkey.devjavu.com/changeset/552

and perhaps the inclusion of the skin folder changesets.

Some form of these are necessary the completion of install.js

Okay getting tired... dropping words. LOL Gnite

On Dec 29, 2007 2:52 AM, Marti <thala...@hotmail.com> wrote:

> http://greasemonkey.devjavu.com/browser/branches/mm1/src/chrome/chrom...

Whoops thought that one was already done. Fixed.

- a

On Dec 29, 2007 1:32 AM, Marti <thala...@hotmail.com> wrote:

>  You are correct... it is not in the base Firefox code, but is actually
> dynamically created by Mozilla with the core distributions of Firefox.  If
> you personally wish to put it back in, it will keep the location consistent
> with previous versions. (e.g. backwards compatibility ;D ) but it not a
> requirement.

I'm only really concerned about backward compatibility of the Greasemonkey API.

> Works great on Linux Firefox... although I suggest removing the comment I
> put in now that you have removed the problem.
>   (<!-- NOTE: Unlocalized accesskey & label in menu tags; possibly
> unaccessible --> ) in line 33.

Really I just moved the problem down a few lines, to the definition of
the menu, right?

- a

Aaron Boodman wrote:

Works great on Linux Firefox... although I suggest removing the comment I
put in now that you have removed the problem.
  (<!-- NOTE: Unlocalized accesskey & label in menu tags; possibly
unaccessible --> ) in line 33.
    

Really I just moved the problem down a few lines, to the definition of
the menu, right?

- a

  

I didn't look down that far... the comment should be closer to the problem then.  I didn't comment everywhere for this type of problem as there would have been several more comments.  You recommended that I not litter the code too much... anywhoo... nice catch. Also missed that Seamonkey comment should be SeaMonkey... you should try misspelling the case in  JavaScript to the wrong person sometime LOL

Marti wrote:

Marti wrote:

I would test out the trunk build in SeaMonkey here, but I must be patient for you to add the missing contents.rdf in the locale too.

For referencing sake:
http://greasemonkey.devjavu.com/browser/branches/mm1/src/chrome/chromeFiles/locale/en-US/contents.rdf?rev=525
http://greasemonkey.devjavu.com/changeset/552

and perhaps the inclusion of the skin folder changesets.

Some form of these are necessary the completion of install.js

Cloned in Changeset 566
Ref: http://greasemonkey.devjavu.com/changeset/566

Thank you! 8D

No problems detected related to this Changeset 562 in SeaMonkey.

Missing Changeset 552 superseded by Changeset 568 (inclusive)
Ref: http://greasemonkey.devjavu.com/changeset/568
Ref: http://greasemonkey.devjavu.com/ticket/76