Re: Custom Field Serializer for EnumMap (issue1634804)

36 views
Skip to first unread message

j...@google.com

unread,
Feb 6, 2012, 4:25:52 PM2/6/12
to bra...@worldviewsoftware.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
There appears to be some problem in how this was created -- the
side-by-side diffs don't work, and Publish+Mail Comments doesn't work.

Basically:
- you need tests
- copyright and code style should match GWT standards
- the limitation on non-empty maps seems too limiting. The GWT
emulation can reach a full set of enum values via keySet, so that could
be used on the client side to avoid this limitation
- the server doesn't appear to read the exemplar value from the stream

http://gwt-code-reviews.appspot.com/1634804/

Bradley Gottfried

unread,
Feb 16, 2012, 11:20:51 AM2/16/12
to google-web-tool...@googlegroups.com, bra...@worldviewsoftware.com, re...@gwt-code-reviews-hr.appspotmail.com, j...@google.com
I put up another set of patches.
http://gwt-code-reviews.appspot.com/1634804/ 
Reply all
Reply to author
Forward
0 new messages