Re: Fix ListBox UiBinder parsing. (issue1629803)

8 views

Skip to first unread message

unread,

Feb 10, 2012, 4:09:08 PM2/10/12

to iter...@google.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com

LGTM, with a couple of nits.

http://gwt-code-reviews.appspot.com/1629803/diff/1/user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java#newcode90
user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java:90:
escaped = escaped.replaceAll("\\s+", " ");
could escaped be null?

http://gwt-code-reviews.appspot.com/1629803/diff/1/user/src/com/google/gwt/uibinder/rebind/XMLElement.java#newcode446
user/src/com/google/gwt/uibinder/rebind/XMLElement.java:446: public
String consumeInnerTextEscapedAsHtmlStringLiteral(Interpreter<String>
interpreter,
This method name is somewhat confusing now -
"consumeInnerTextEscapedAsHtmlStringLiteral" - does that name still
apply even if html entities are not escaped?