Google Web Toolkit Contributors Google Group

Re: Benchmark for widget creation times

j...@google.com (Joel Webber) — Tue, 05 Jan 2010 01:47:51 UT

SGTM. I've got more to add once it's in.

Re: Benchmark for widget creation times

rj...@google.com — Tue, 05 Jan 2010 01:29:15 UT

Picked up last rounds of feedback from Joel (EmptyBinder weirdness),
Thomas and James. Also checkstyle fixes.
Barring further objections, I'll submit this in the morning. There are
more tests that could be implemented (Joel may have written them
already), but I'd like to get in what I have.
[link]

Re: [gwt-contrib] Possible bug in DOMImplMozilla

jlaba...@google.com (John LaBanca) — Mon, 04 Jan 2010 21:39:54 UT

I'll look into it tomorrow morning.
Thanks,
John LaBanca
jlaba...@google.com

Re: [gwt-contrib] Removing the deprecated XxxListeners

t.bro...@gmail.com (Thomas Broyer) — Mon, 04 Jan 2010 20:09:28 UT

That's Really. Good. News!
(thanks for this birthday gift ;-) )

Re: [gwt-contrib] Possible bug in DOMImplMozilla

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 19:37:32 UT

Looks like you're right about that.
@jlabanca: Correct me if I'm wrong, but didn't you refactor this stuff a
while back? Mind having a look to make sure I'm not missing something?

Re: JSNI references with * as the parameter list

sp...@google.com (Lex Spoon) — Mon, 04 Jan 2010 19:36:57 UT

As would be expected, the trickiest part of this patch has to do with
overloading and inheritance. These are dark corners that good code will not
rely on, but our tools have to do something with them.
I'm not in love with the current algorithm, but what precisely shall we do?
It's certainly important, but let's be careful not to bike shed the corner

[google-web-toolkit] r7352 committed - Fix external issue 4048 - make java.sql.Timestamp emulation...

codesite-nore...@google.com — Mon, 04 Jan 2010 19:07:01 UT

Revision: 7352
Author: r...@google.com
Log: Fix external issue 4048 - make java.sql.Timestamp emulation
more lenient about the formatting of the nanoseconds field.
Review by: jat
[link]
Modified:
/trunk/user/super/com/google/g wt/emul/java/sql/Timestamp.jav a

Re: RFE: deprecate user.client.Element and user.client.DOM

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 19:02:20 UT

I think I just inadvertently replied to this on another thread, but
yes -- this is something we need to get on our roadmap very soon.

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 18:48:55 UT

Thanks, Alejandro. I'll reproduce this locally and enter an issue for it. It
sounds like the issue might have something to do with having a block-level
element *inside* the tabs two existing divs. float:left on just the
outer-most element is supposed to work here, but perhaps that's not enough
on IE.

Re: [gwt-contrib] Removing the deprecated XxxListeners

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 18:45:20 UT

A hearty +1 from me. We've been needing to do this for a while, but have
been so heads-down on new features that it's fallen by the wayside. On that
note, we also need to deprecate the DOM class and fix all the widgets to not
use it (all its functionality was subsumed by Document/Element a long time

Re: JSNI references with * as the parameter list

b...@google.com — Mon, 04 Jan 2010 18:26:37 UT

[link]
File dev/core/test/com/google/gwt/d ev/jjs/impl/JsniRefLookupTest. java
(right):
[link]
Line 234: JMethod res = (JMethod) lookup("test.Bar::foo(*)", errors);
It seems weird that this should work. If Bar didn't declare foo() (and

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

aga...@gmail.com (Alejandro D. Garin) — Mon, 04 Jan 2010 17:30:33 UT

Hi,
I ran into the same issue with IE7/8 using the css example you suggested
here:
[link]
but adding float:left to:
.gwt-TabLayoutPanelTab {
background: url(tab-inactive-left.png) no-repeat bottom left;
float:left;

Re: JsDuplicateFunctionRemover

sp...@google.com — Mon, 04 Jan 2010 17:28:18 UT

The code looks good, but I'd like to try it out before a final approval.
Can you repost a patch with the missing little bits fixed up?
[link]
File dev/core/src/com/google/gwt/de v/jjs/JavaToJavaScriptCompiler .java
(right):
[link]

Re: [gwt-contrib] Re: StackLayoutPanel has no styles at all??

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 17:05:01 UT

You're right, there is no notification to stack-header widgets of their
selection state. I'll make a note to add a standard way for them to be
notified of this.
As for standard CSS, with the current design (i.e., your own widget is the
only header element), there's nothing to add a default style to. Perhaps we

Re: [gwt-contrib] Re: TabLayoutPanel not working on IE8

j...@google.com (Joel Webber) — Mon, 04 Jan 2010 17:01:05 UT

Which element did you have to add float:left to? It's set manually in code
to the outermost tab element, which is all that *should* be necessary.