Use a fully qualified bean name in the GwtSpecificValidatorCreator (issue1865803)

12 views
Skip to first unread message

nch...@google.com

unread,
Nov 6, 2012, 5:28:55 PM11/6/12
to cromw...@google.com, google-web-tool...@googlegroups.com, re...@gwt-code-reviews-hr.appspotmail.com
Reviewers: cromwellian,

Description:
Use a fully qualified bean name in the GwtSpecificValidatorCreator
field Wrapper.
Fixes issues: 7749


Please review this at http://gwt-code-reviews.appspot.com/1865803/

Affected files:
M
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java


Index:
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
===================================================================
---
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(revision 11367)
+++
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(working copy)
@@ -1112,14 +1112,14 @@
private void writeFieldWrapperMethod(SourceWriter sw, JField field) {
writeUnsafeNativeLongIfNeeded(sw, field.getType());

- // private native fieldType _fieldName(Bean object) /*-{
+ // private native fieldType _fieldName(com.example.Bean object) /*-{
sw.print("private native ");

sw.print(field.getType().getQualifiedSourceName());
sw.print(" ");
sw.print(toWrapperName(field));
sw.print("(");
- sw.print(beanType.getName());
+ sw.print(field.getEnclosingType().getQualifiedSourceName());
sw.println(" object) /*-{");
sw.indent();



Reply all
Reply to author
Forward
0 new messages