Code Review requested on DateBox

1 view
Skip to first unread message

Ray Ryan

unread,
Nov 22, 2008, 12:25:19 AM11/22/08
to John Labanca, Google Web Toolkit Contributors, Emily Crutcher
Hey, John. 

This is not small, I'm afraid, but it's not outrageous either. It's already committed to the 1_6_date_picker branch, and can be reviewed there. 


From the change log:

Makes DateBox implement ValueChange, and makes it, like, work. Adds unit tests
for DateBox and DatePicker. Removes some broken event handling methods from
DateBox that aren't worth fixing b/c they can be done directly to its textbox
instead. Adds notion of an autoHidePartner to PopupPanel, to keep picker from
disappearing during mouse events in the date box text field. Should be generally
useful.
Reply all
Reply to author
Forward
0 new messages