Implement round-trip validation with RequestFactory and the Editor framework. (issue877801)

[bo...@google.com]

Reviewers: rjrjr,

Message:
Can you take a look at the overall API and use patterns? I still need
to write tests for pushing validation errors around, but I think this
implementation is close to where it will wind up.

Description:
Implement round-trip validation with RequestFactory and the Editor
framework.
Patch by: bobv
Review by: rjrjr

Please review this at http://gwt-code-reviews.appspot.com/877801/show

Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.ui.xml
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.ui.xml
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java
M user/src/com/google/gwt/editor/client/Editor.java
M user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
M user/src/com/google/gwt/editor/client/impl/AbstractEditorDelegate.java
M
user/src/com/google/gwt/editor/client/impl/AbstractSimpleBeanEditorDriver.java
A user/src/com/google/gwt/editor/client/impl/DelegateMap.java
M user/src/com/google/gwt/editor/client/impl/SimpleBeanEditorDelegate.java
D user/src/com/google/gwt/editor/client/ui/EditorErrorPanel.java
D user/src/com/google/gwt/editor/client/ui/EditorErrorPanel.ui.xml
A user/src/com/google/gwt/editor/client/ui/ValueBoxEditorDecorator.java
A user/src/com/google/gwt/editor/client/ui/ValueBoxEditorDecorator.ui.xml
M user/src/com/google/gwt/editor/rebind/AbstractEditorDriverGenerator.java
M
user/src/com/google/gwt/editor/rebind/SimpleBeanEditorDriverGenerator.java
M user/src/com/google/gwt/editor/rebind/model/EditorModel.java
M
user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java
M
user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactoryEditorDriver.java
M
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java
M
user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java
M
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryEditorDriverGenerator.java
M user/src/com/google/gwt/user/client/ui/ValueBoxBase.java
M user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java

[rj...@google.com]

LGTM

ErrorPanel didn't work out, eh?

Delegate map is required for interpreting violation paths?

http://gwt-code-reviews.appspot.com/877801/diff/2001/3003
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3003#newcode35
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java:35:
ValueBoxEditorDecorator<String> street;
That's quite a mouthful. Don't have a better name off the top of my
head, though.

http://gwt-code-reviews.appspot.com/877801/diff/2001/3005
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3005#newcode49
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/PersonEditor.java:49:
@Ignore
How come?

http://gwt-code-reviews.appspot.com/877801/diff/2001/3009
File user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java
(right):

http://gwt-code-reviews.appspot.com/877801/diff/2001/3009#newcode53
user/src/com/google/gwt/editor/client/adapters/ValueBoxEditor.java:53:
getDelegate().recordError(e.getMessage(), peer.getText(), e);
// TODO i18n
getDelegate().recordError(e.getMessage(), "Bad value (" +
peer.getText() + ")", e);

http://gwt-code-reviews.appspot.com/877801/show