[google-toolbox-for-mac] r563 committed - [Author: mmentovai]...

4 views
Skip to first unread message

google-tool...@googlecode.com

unread,
Aug 3, 2012, 11:30:20 AM8/3/12
to google-tool...@googlegroups.com
Revision: 563
Author: gtm.daemon
Date: Fri Aug 3 08:30:12 2012
Log: [Author: mmentovai]

Fix error-case memory leak in GTMSMJobRemove.

GTMPerformOnLabel will create an error in &local_error when it returns
NULL, so there is no need to create yet another error in local_error.
It masks the error created by GTMPerformOnLabel, which is leaked.

R=dmaclach,thomasvl
APPROVED=thomasvl
DELTA=2 (0 added, 2 deleted, 0 changed)
http://code.google.com/p/google-toolbox-for-mac/source/detail?r=563

Modified:
/trunk/Foundation/GTMServiceManagement.c

=======================================
--- /trunk/Foundation/GTMServiceManagement.c Fri Sep 9 15:00:25 2011
+++ /trunk/Foundation/GTMServiceManagement.c Fri Aug 3 08:30:12 2012
@@ -663,8 +663,6 @@
break;
}
launch_data_free(resp);
- } else {
- local_error = GTMCFLaunchCreateUnlocalizedError(errno, CFSTR(""));
}
if (error) {
*error = local_error;
Reply all
Reply to author
Forward
0 new messages