Web Images Videos Maps News Shopping Gmail more »
Recently Visited Groups | Help | Sign in
Google Groups Home
Issue 44 in google-sparsehash: windows/port.cc:TmpFile returns a pointer to a local varaible
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
codesite-nore...@google.com  
View profile  
 More options Oct 7, 5:16 pm
From: codesite-nore...@google.com
Date: Wed, 07 Oct 2009 21:16:24 +0000
Local: Wed, Oct 7 2009 5:16 pm
Subject: Issue 44 in google-sparsehash: windows/port.cc:TmpFile returns a pointer to a local varaible
Status: New
Owner: ----

New issue 44 by jrleek: windows/port.cc:TmpFile returns a pointer to a  
local varaible
http://code.google.com/p/google-sparsehash/issues/detail?id=44

We found this bug with a static analysis tool.  It's an easy fix.  Line 55
of src/windows/port.cc has:

char tmppath_buffer[1024];

line 62 has:

return tmppath_buffer;

oops.

What version of the product are you using? On what operating system?

I found this in version 1.3, but it's still there in 1.5.2.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
codesite-nore...@google.com  
View profile  
 More options Oct 11, 8:18 pm
From: codesite-nore...@google.com
Date: Mon, 12 Oct 2009 00:18:49 +0000
Local: Sun, Oct 11 2009 8:18 pm
Subject: Issue 44 in google-sparsehash: windows/port.cc:TmpFile returns a pointer to a local varaible
Updates:
        Status: WontFix
        Labels: Type-Defect Priority-Medium

Comment #1 on issue 44 by csilvers: windows/port.cc:TmpFile returns a  
pointer to a local varaible
http://code.google.com/p/google-sparsehash/issues/detail?id=44

This is actually fine -- the function returns a string, not a pointer, so  
the local
buffer is converted to a string before being returned.

I'm closing this as NotABug.  Though maybe it's a good bug to file with the  
static
analysis tool? :-)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google