New issue 184 by mrabkin: pprof --raw output has slight bug with remote  
fetch
http://code.google.com/p/google-perftools/issues/detail?id=184

Problem 1:
$ pprof --raw host:port/pprof/profile > file.raw
$ pprof --text file.raw
file.raw: Cannot recognize profile section after symbols.

Perftools version 1.4 had a slight bug in my previous patch, where the
symbolized profile data is in a slightly wrong format when used with remote
fetch.  The attached patch fixes this problem by fixing the output
format (adds a necessary header line).

Problem 2:
$ pprof host:port//prof/profile
<waits for 60 extra seconds before completing due to timeout in 'wget')

On my versions of linux (Fedora Core 4 and Centos 5.2) the 'wget' by
default sets a "Connection: Keep-Alive" header for some reason, which some
of our servers respect and respond to be keeping a connection open and not
closing the socket.  This causes remote fetch from pprof to potentially
take an extra 60 seconds until 'wget' closes the connection.  The patch
also adds a "--no-http-keepalive" flag to wget to avoid this delay.

Attachments:
        pprof.patch  1.4 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Comment #1 on issue 184 by csilvers: pprof --raw output has slight bug with  
remote fetch
http://code.google.com/p/google-perftools/issues/detail?id=184

Thanks for these fixes!

I checked my version of wget, and it does not support a --http-keepalive (or
--no-http-keepalive) flag.  So the second version of the patch would break  
at least
some users.  One way to fix it is to try with the flag, and then without if  
it fails
-- see how we already do that elsewhere in pprof, with nm.  In fact, we  
could even
use curl, and GET, if wget is not installed on a given machine; you could  
try all the
commands in order until one works.

Do you want to supply a new patch that makes the wget a bit safer?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Comment #2 on issue 184 by csilvers: pprof --raw output has slight bug with  
remote fetch
http://code.google.com/p/google-perftools/issues/detail?id=184

I've patched in the fix for problem 1, but haven't done anything with  
problem 2 yet.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Comment #3 on issue 184 by mrabkin: pprof --raw output has slight bug with  
remote fetch
http://code.google.com/p/google-perftools/issues/detail?id=184

WGET option patch attached.  Unfortunately, WGET returns zero (success)  
codes for bad
options, so I grep for an error message.

Attachments:
        pprof_wget_options.patch  849 bytes

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Comment #4 on issue 184 by csilvers: pprof --raw output has slight bug with  
remote fetch
http://code.google.com/p/google-perftools/issues/detail?id=184

I think your patch is missing the part where we actually use WGET_OPTIONS  
when
running wget commands.  I added that into pprof, and will make that part of  
the next
svn push.

btw, thanks for fixing up the version number. :-)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings