patch to LabeledMarker - improved visibility control - Google Maps Utility Library

Messages 1 - 25 of 34 - Collapse all

Newer >

Sergey Ushakov

View profile

More options Nov 12 2008, 5:31 pm

From: Sergey Ushakov <s-n-usha...@nm.ru>

Date: Wed, 12 Nov 2008 14:31:31 -0800 (PST)

Local: Wed, Nov 12 2008 5:31 pm

Subject: patch to LabeledMarker - improved visibility control

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

Hi,

and first special thanks to Mike Purvis, as I have learned a lot while
examining his LabeledMarker...

Meanwhile during my first experience of using it in my project I ran
into several visibility issues. The patch to fix them is appended
below.

1) The current release version (1.2) of LabeledMarker does not allow
setting up visibility before .addOverlay()/.initialize(). It produces
an error due to .div_ not having been created yet. Normal overlays
(polylines, etc) do allow this. Solution: move .div_ creation code
from .initialize() to the constructor.

2) Labels are forced to be visible at .addOverlay()/.initialize()
even if they were made hidden before. Solution: add helper
method .applyLabelVisibility_() and call it consistently from .show
(), .hide(), .setLabelVisibility().

3) LabeledMarker inherits from the GMarker the problem that it is
always visible after having been added to a map, regardless of the
visibility status assigned before (unlike other standard overlays).
Solution: add extra private property .ownVisibility_ to store assigned
visibility status and use it along with .applyLabelVisibility_() where
appropriate - in .initialize(), .show(), .hide().

Any comments will be most appreciated.

Regards,
Sergey

-------------------

--- labeledmarker-1.2.js 2008-11-13 00:47:31.000000000 +0300
+++ labeledmarker-new.js 2008-11-13 00:53:07.000000000 +0300
@@ -24,7 +24,7 @@

/**
* Constructor for LabeledMarker, which picks up on strings from the
GMarker
- * options array, and then calls the GMarker constructor.
+ * options array, creates the div, and then calls the GMarker
constructor.
*
* @param {GLatLng} latlng
* @param {GMarkerOptions} Named optional arguments:
@@ -45,7 +45,18 @@
this.clickable_ = opt_opts.clickable || true;
this.title_ = opt_opts.title || "";
this.labelVisibility_ = true;
+ // That's a workaround for the problem with GMarker that it unlike
other
+ // GOverlay's is always visible after addOverlay(), regardless if
having
+ // been hidden before it
+ this.ownVisibility_ = true;

+ this.div_ = document.createElement("div");
+ this.div_.className = this.labelClass_;
+ this.div_.innerHTML = this.labelText_;
+ this.div_.style.position = "absolute";
+ this.div_.style.cursor = "pointer";
+ this.div_.title = this.title_;
+
if (opt_opts.draggable) {
// This version of LabeledMarker doesn't support dragging.
opt_opts.draggable = false;
@@ -61,8 +72,8 @@
LabeledMarker.prototype = new GMarker(new GLatLng(0, 0));

/**
- * Is called by GMap2's addOverlay method. Creates the text div and
adds it
- * to the relevant parent div.
+ * Is called by GMap2's addOverlay method. Adds the text div to the
relevant
+ * parent div.
*
* @param {GMap2} map the map that has had this labeledmarker added
to it.
*/
@@ -71,13 +82,12 @@
GMarker.prototype.initialize.apply(this, arguments);

this.map_ = map;
- this.div_ = document.createElement("div");
- this.div_.className = this.labelClass_;
- this.div_.innerHTML = this.labelText_;
- this.div_.style.position = "absolute";
- this.div_.style.cursor = "pointer";
- this.div_.title = this.title_;

+ if (!this.ownVisibility_)
+ {
+ this.hide();
+ }
+ this.applyLabelVisibility_();
map.getPane(G_MAP_MARKER_PANE).appendChild(this.div_);

if (this.clickable_) {
@@ -162,11 +172,8 @@
*/
LabeledMarker.prototype.show = function() {
GMarker.prototype.show.apply(this, arguments);
- if (this.labelVisibility_) {
- this.showLabel();
- } else {
- this.hideLabel();
- }
+ this.ownVisibility_ = true;
+ this.applyLabelVisibility_();
};

@@ -176,7 +183,8 @@
*/
LabeledMarker.prototype.hide = function() {
GMarker.prototype.hide.apply(this, arguments);
- this.hideLabel();
+ this.ownVisibility_ = false;
+ this.applyLabelVisibility_();
};

@@ -195,13 +203,7 @@
*/
LabeledMarker.prototype.setLabelVisibility = function(visibility) {
this.labelVisibility_ = visibility;
- if (!this.isHidden()) { // Marker showing, make visible change
- if (this.labelVisibility_) {
- this.showLabel();
- } else {
- this.hideLabel();
- }
- }
+ this.applyLabelVisibility_();
};

@@ -215,6 +217,18 @@

/**
+ * Updates actual label visibility depending on marker and label
settings.
+ */
+LabeledMarker.prototype.applyLabelVisibility_ = function () {
+ if ((!this.isHidden()) && this.labelVisibility_) {
+ this.showLabel();
+ } else {
+ this.hideLabel();
+ }
+};
+
+
+/**
* Hides the label of the marker.
*/
LabeledMarker.prototype.hideLabel = function() {

Reply to author Forward

pamela fox

View profile

More options Nov 12 2008, 5:54 pm

From: "pamela fox" <pamela....@gmail.com>

Date: Thu, 13 Nov 2008 09:54:29 +1100

Local: Wed, Nov 12 2008 5:54 pm

Subject: Re: patch to LabeledMarker - improved visibility control

  Reply to author
  |
  Forward
  | Print
  | Individual message
  | Show original
  | Report this message
  | Find messages by this author
  

Hey Sergey-
It looks good. I was the one that wrote all the show/hide stuff for
LabeledMarker, and I remember that I wasn't quite sure what developers would
expect the behavior to be. I assume that my current example of show/hide
still works correctly with this change in code?
Would you like to join the project and patch in the code, or have someone
else patch it in for you?

Thanks!