How's HEAD working out for everyone?

[Sam Berlin]

Just curious: have folks experimented with the latest code that Christian synced to the trunk the other day?  How's it working out for ya'll?

 sam

[Stuart McCulloch]

On 28 May 2013, at 20:45, Sam Berlin wrote:

> Just curious: have folks experimented with the latest code that Christian synced to the trunk the other day? How's it working out for ya'll?

Have all the internal changes been sync'd to the public repo? I was waiting for the 'all-clear' before rebasing my local fork and giving it a spin with various projects.

> sam

[Sam Berlin]

Yeah, I think we missed the "all-clear", but AFAIK they're all pushed out now.  Christian, anything else pending that I'm missing?

 sam

--
You received this message because you are subscribed to the Google Groups "google-guice" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-guice...@googlegroups.com.
To post to this group, send email to google...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

[Christian Gruber]

Crap. I thought my all-clear was in the announcement e-mail I made to
the guice list. Sorry Stuart.

"All clear"

:/

Christian.

Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency
Injection
email: cgr...@google.com :::: mobile: +1 (646) 807-9839

[Stuart McCulloch]

Righto - btw, I don't see the patch to fix the Maven build in trunk:

https://groups.google.com/d/msg/google-guice/upaMsMfeulI/dyavaZ6WfmUJ

IIRC this was going to be applied on your side and should then appear via the restored sync process?

[Christian Gruber]

Er… let me check on that. :/

c.

[Tim Boudreau]

On Tuesday, May 28, 2013 7:36:10 PM UTC-4, Stuart McCulloch wrote:

Righto - btw, I don't see the patch to fix the Maven build in trunk:

        https://groups.google.com/d/msg/google-guice/upaMsMfeulI/dyavaZ6WfmUJ

+1 - I can't test it until I can build it (yes, I could build it locally with Ant, but all of my projects are going to look in my maven repo for it, which is...the Jenkins Maven Repo plugin over whatever it built...with Maven...).

-Tim

 

[Christian Gruber]

Checking on this right now. I'll get something out by EOD. Sorry folks.

Christian.

On 28 May 2013, at 16:36, Stuart McCulloch wrote:

[Tim Boudreau]

On Wednesday, May 29, 2013 11:46:09 AM UTC-4, Christian Gruber wrote:

Checking on this right now.  I'll get something out by EOD.  Sorry folks.

 Erm, ping?

-Tim

[Christian Gruber]

I'm really sorry everyone. Trying to keep things moving on several
fronts, I dropped this on the floor. :( I just pushed the fix to the
maven build. Please have at it. Once I'm done our process should be
much simpler, easier to keep in sync, and done in small increments.

Christian

[Tim Boudreau]

On Thursday, June 6, 2013 6:57:24 PM UTC-4, Christian Gruber wrote:

I'm really sorry everyone.  Trying to keep things moving on several
fronts, I dropped this on the floor. :(  I just pushed the fix to the
maven build.  Please have at it.  Once I'm done our process should be
much simpler, easier to keep in sync, and done in small increments.

Woo hoo!  All my failing builds are building again!  Thanks much, and sorry to be a pest about it!

-Tim

[Christian Gruber]

It's not a pest thing at all. Thank you for giving me the signal. Let
us know if things are problematic (aside from now-fixed build issues)

Christian.

[Stuart McCulloch]

Thanks, I've been trying out the latest code with some local projects and so far it's looking good.

I also rebased various patches so they apply cleanly on top of master - the one I'm most interested in is:

https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_709_externalize_guava_dependency.patch

But I'd also be OK with deferring this and cutting a release asap rather than cause any further delays.

FYI, other build related patches are:

https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_719_simplify_jarjar_build_setup.patch (depends on #709)
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_720_minor_build_improvements.patch

It would also be nice to get some of the following minor patches in, but they can wait until the next dot release:

https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_288_decouple_thread_local.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_350_robust_system_get_property.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_618_extensible_filter_pipeline.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_695_persistence_properties_provider.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_723_decouple_anon_type_converters.patch
https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_748_private_modules.patch

--
Cheers, Stuart

[Christian Gruber]

The former has been on my list to take on, so this particular case, the
patch is well received and appreciated. The first three I feel I can
take on without much of Sam's perspective, but the others I'd rather
take a bit more time and discuss, and that will have to wait for Sam to
return. Let me try to get these build-related changes in, and we can
cut a release-candidate.

cheers,
Christian.

[Sam Berlin]

... back from honeymoon now.  Let's split out the questions into a separate thread and talk about them.  In general, I'm keen on patches that don't change the API or introduce more hidden/required dependencies, especially if there's no downsides to speak of.

 sam

To unsubscribe from this group and stop receiving emails from it, send an email to google-guice+unsubscribe@googlegroups.com.

To post to this group, send email to google...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency Injection
email: cgr...@google.com :::: mobile: +1 (646) 807-9839

--
You received this message because you are subscribed to the Google Groups "google-guice" group.

To unsubscribe from this group and stop receiving emails from it, send an email to google-guice+unsubscribe@googlegroups.com.

To post to this group, send email to google...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "google-guice" group.

To unsubscribe from this group and stop receiving emails from it, send an email to google-guice+unsubscribe@googlegroups.com.

To post to this group, send email to google...@googlegroups.com.
Visit this group at http://groups.google.com/group/google-guice?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Christian Gruber :: Google, Inc. :: Java Core Libraries :: Dependency Injection
email: cgr...@google.com :::: mobile: +1 (646) 807-9839

--
You received this message because you are subscribed to the Google Groups "google-guice" group.

To unsubscribe from this group and stop receiving emails from it, send an email to google-guice+unsubscribe@googlegroups.com.