[google-guice] push by cgruber@google.com - Fix issue 663: Grapher is producing corrupt graphs... on 2013-05-16 15:03 GMT

2 views
Skip to first unread message

google...@googlecode.com

unread,
May 16, 2013, 11:04:03 AM5/16/13
to google-g...@googlegroups.com
Revision: ad6584a05616
Author: Christian Edward Gruber <cgr...@google.com>
Date: Thu May 16 07:56:20 2013
Log: Fix issue 663: Grapher is producing corrupt graphs

This CL fixes issue 663, where implementation and instance nodes are set to
be style=invis causing them not to show up on the Guice graph:
https://code.google.com/p/google-guice/issues/detail?id=663&q=grapher&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary%20Component

See here for the workaround that led to this solution:
http://stackoverflow.com/questions/9301007/is-there-any-way-to-get-guice-grapher-to-work

------------------
Manually Synced.
COMMIT=44428433

http://code.google.com/p/google-guice/source/detail?r=ad6584a05616

Modified:

/extensions/grapher/src/com/google/inject/grapher/graphviz/GraphvizGrapher.java

=======================================
---
/extensions/grapher/src/com/google/inject/grapher/graphviz/GraphvizGrapher.java
Fri Jul 22 14:14:53 2011
+++
/extensions/grapher/src/com/google/inject/grapher/graphviz/GraphvizGrapher.java
Thu May 16 07:56:20 2013
@@ -249,7 +249,7 @@
@Override protected void newImplementationNode(ImplementationNode node) {
NodeId nodeId = node.getId();
GraphvizNode gnode = new GraphvizNode(nodeId);
- gnode.setStyle(NodeStyle.INVISIBLE);
+ gnode.setStyle(NodeStyle.SOLID);

gnode.setHeaderBackgroundColor("#000000");
gnode.setHeaderTextColor("#ffffff");
@@ -265,7 +265,7 @@
@Override protected void newInstanceNode(InstanceNode node) {
NodeId nodeId = node.getId();
GraphvizNode gnode = new GraphvizNode(nodeId);
- gnode.setStyle(NodeStyle.INVISIBLE);
+ gnode.setStyle(NodeStyle.SOLID);

gnode.setHeaderBackgroundColor("#000000");
gnode.setHeaderTextColor("#ffffff");
Reply all
Reply to author
Forward
0 new messages