Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
A lice-sized code review (suzhe localrev 1625)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
james...@gmail.com  
View profile  
 More options Jan 18 2010, 3:16 am
From: james...@gmail.com
Date: Mon, 18 Jan 2010 00:16:55 -0800 (PST)
Local: Mon, Jan 18 2010 3:16 am
Subject: A lice-sized code review (suzhe localrev 1625)
Hello phnixwxz,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r1625:  suzhe | 2010-01-18 16:15:17 +0800

- Fix test XMLHttpRequest.AbortAfterFinished of soup-xml-http-request extension.
- Apply patch of issue 336: Show Qt / Gtk shortcuts in the respective desktop environments
----------------------------------------------------------------------

=== extensions/soup_xml_http_request/tests/soup_xml_http_request_test.cc
==================================================================
--- extensions/soup_xml_http_request/tests/soup_xml_http_request_test.cc        (revision 1624)
+++ extensions/soup_xml_http_request/tests/soup_xml_http_request_test.cc        (revision 1625)
@@ -617,7 +617,7 @@
   ASSERT_EQ(XMLHttpRequestInterface::NO_ERR,
             request->SetRequestHeader("TestHeader", "TestHeaderValue"));
   ASSERT_EQ(XMLHttpRequestInterface::OPENED, request->GetReadyState());
-  ASSERT_EQ(XMLHttpRequestInterface::ABORT_ERR, request->Send(std::string()));
+  ASSERT_EQ(XMLHttpRequestInterface::NO_ERR, request->Send(std::string()));
   // no additional readystatechange signal.
   ASSERT_EQ(5, callback.callback_count_);
   ASSERT_TRUE(callback.aborted_);
=== extensions/soup_xml_http_request/tests/Makefile.am
==================================================================
--- extensions/soup_xml_http_request/tests/Makefile.am  (revision 1624)
+++ extensions/soup_xml_http_request/tests/Makefile.am  (revision 1625)
@@ -22,6 +22,7 @@
                  -I$(top_srcdir)

 LDADD          = $(PTHRREAD_LIBS) \
+                 $(GTK2_LIBS) \
                  $(top_builddir)/unittest/libgtest.la \
                  $(top_builddir)/ggadget/libggadget@GGL_EPOCH@.la \
                  $(top_builddir)/ggadget/gtk/libggadget-gtk@GGL_EPOCH@.la
=== hosts/qt/ggl-qt.desktop.in
==================================================================
--- hosts/qt/ggl-qt.desktop.in  (revision 1624)
+++ hosts/qt/ggl-qt.desktop.in  (revision 1625)
@@ -10,3 +10,4 @@
 Type=Application
 Categories=KDE;Qt;Network;News;
 MimeType=application/x-google-gadget;app/gg;
+OnlyShowIn=KDE;
=== hosts/gtk/ggl-gtk.desktop.in
==================================================================
--- hosts/gtk/ggl-gtk.desktop.in        (revision 1624)
+++ hosts/gtk/ggl-gtk.desktop.in        (revision 1625)
@@ -10,3 +10,4 @@
 Type=Application
 Categories=GNOME;GTK;Network;News;
 MimeType=application/x-google-gadget;app/gg;
+OnlyShowIn=GNOME;XFCE;

This is a semiautomated message from "svkmail".  Complaints or suggestions?
Mail edy...@gmail.com.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Xianzhu Wang  
View profile  
 More options Jan 18 2010, 3:26 am
From: Xianzhu Wang <phnix...@gmail.com>
Date: Mon, 18 Jan 2010 16:26:02 +0800
Local: Mon, Jan 18 2010 3:26 am
Subject: Re: [ggl-dev] A lice-sized code review (suzhe localrev 1625)
LGTM.

2010/1/18  <james...@gmail.com>:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »