A snake-sized code review (jimz localrev 722)

[zhuan...@gmail.com]

Hello phnixwxz, james.su,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r722: jimz | 2008-07-09 19:09:17 +0800

More tweaks to rss gadget
----------------------------------------------------------------------

=== gadgets/rss/zh-CN/strings.xml
==================================================================
--- gadgets/rss/zh-CN/strings.xml (revision 721)
+++ gadgets/rss/zh-CN/strings.xml (revision 722)
@@ -31,4 +31,5 @@
<GADGET_REMOVE>删除</GADGET_REMOVE>
<GADGET_MAXSHOW>每个剪辑最多可显示的条目:</GADGET_MAXSHOW>
<GADGET_DEFAULTURL>http://news.google.cn/?output=rss</GADGET_DEFAULTURL>
+<GADGET_UNTITLED>《无标题》</GADGET_UNTITLED>
</strings>
=== gadgets/rss/options.xml
==================================================================
--- gadgets/rss/options.xml (revision 721)
+++ gadgets/rss/options.xml (revision 722)
@@ -32,7 +32,7 @@
width="100%" height="100%"/>
<listbox name="feeds" width="348" height="298" x="1" y="1"
background="#ffffff" autoscroll="true" itemHeight="35"
- onchange="SelectedFeedChanged();"/>
+ itemWidth="100%" onchange="SelectedFeedChanged()"/>
</div>
<button x="250" y="355" width="100" name="removebutton"
onclick="RemoveFeed()" caption="&GADGET_REMOVE;"
=== gadgets/rss/en/strings.xml
==================================================================
--- gadgets/rss/en/strings.xml (revision 721)
+++ gadgets/rss/en/strings.xml (revision 722)
@@ -31,4 +31,5 @@
<GADGET_REMOVE>Remove</GADGET_REMOVE>
<GADGET_MAXSHOW>Maximum number of entries to show for a clip:</GADGET_MAXSHOW>
<GADGET_DEFAULTURL>http://news.google.com/?output=rss</GADGET_DEFAULTURL>
+<GADGET_UNTITLED>&lt;untitled&gt;</GADGET_UNTITLED>
</strings>
=== gadgets/rss/options.js
==================================================================
--- gadgets/rss/options.js (revision 721)
+++ gadgets/rss/options.js (revision 722)
@@ -96,8 +96,8 @@
gadget.debug.trace("Adding feed: " + feed.url);
var title = feed.title;
if (!title) {
- title = "&lt;untitled&gt;";
+ title = strings.GADGET_UNTITLED;
}
- var item = "<item><label>" + title + "\n" + feed.url + "</label></item>";
- feeds.appendElement(item);
+ var item = title + "\n" + feed.url;
+ feeds.appendString(item);
}

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

[Zhe Su]

LGTM.