ExCanvas patch for paths

4 views
Skip to first unread message

Erik Arvidsson

unread,
Mar 6, 2008, 2:41:49 AM3/6/08
to EAE, Glen Murphy, google-...@googlegroups.com
Hi Emil and Glen,

I would like you to do a code review of the attached patch.

* This fixes issues where translate, rotate and scale is used during a
path is being constructed. Previously we did the coord translations
just before we draw the path. That is incorrect and now we do the
translations when we add each individual piece to the path

* Added very limited support for scaling of the stroke width.
Currently we do the scaling by calculating the position in the final
coordinate space and we therefore cannot do non uniform scaling of the
stroke. For now we just do the max x/y scale factor.

* Added one more test to test the path with scaling, rotating and translating

--
erik

scale-rotate-stroke.patch

Emil A Eklund

unread,
Mar 6, 2008, 5:04:56 PM3/6/08
to google-...@googlegroups.com, Glen Murphy
On Wed, 2008-03-05 at 23:41 -0800, Erik Arvidsson wrote:
> I would like you to do a code review of the attached patch.

Looks good to me. Thanks for fixing it!

--
Emil A Eklund
e...@eae.net

signature.asc
Reply all
Reply to author
Forward
0 new messages