Google Groups Home
Help | Sign in
ExCanvas patch for paths
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Erik Arvidsson  
View profile
 More options Mar 6, 2:41 am
From: "Erik Arvidsson" <erik.arvids...@gmail.com>
Date: Wed, 5 Mar 2008 23:41:49 -0800
Local: Thurs, Mar 6 2008 2:41 am
Subject: ExCanvas patch for paths

Hi Emil and Glen,

I would like you to do a code review of the attached patch.

* This fixes issues where translate, rotate and scale is used during a
path is being constructed.  Previously we did the coord translations
just before we draw the path.  That is incorrect and now we do the
translations when we add each individual piece to the path

* Added very limited support for scaling of the stroke width.
Currently we do the scaling by calculating the position in the final
coordinate space and we therefore cannot do non uniform scaling of the
stroke.  For now we just do the max x/y scale factor.

* Added one more test to test the path with scaling, rotating and translating

--
erik

  scale-rotate-stroke.patch
19K Download

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Emil A Eklund  
View profile
 More options Mar 6, 5:04 pm
From: Emil A Eklund <e...@eae.net>
Date: Thu, 06 Mar 2008 14:04:56 -0800
Local: Thurs, Mar 6 2008 5:04 pm
Subject: Re: ExCanvas patch for paths

On Wed, 2008-03-05 at 23:41 -0800, Erik Arvidsson wrote:
> I would like you to do a code review of the attached patch.

Looks good to me. Thanks for fixing it!

--
Emil A Eklund
e...@eae.net

  signature.asc
< 1K Download

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google