Issue 1171 in google-caja: IE[67] throws when setting type of buttons

[googl...@googlecode.com]

Status: Started
Owner: felix8a
Labels: Type-Defect Priority-Medium

New issue 1171 by felix8a: IE[67] throws when setting type of buttons
http://code.google.com/p/google-caja/issues/detail?id=1171

Unlike other browsers, IE[67] doesn't let you change the
type of a <button> element.

In IE[67] without caja, el.setAttribute('type', 'button') silently fails.
In IE[67] using caja, el.setAttribute('type', 'button') throws an error.
the inconsistency is a problem.
I think I'm going to make it silently fail.

so.. there are three plausible methods of changing a button's type:

SA
button.setAttribute('type', foo);

SN
a = document.createAttribute('type');
a.value = foo;
button.setAttributeNode(a);

SP
button.type = foo;

and this is how browsers behave

chrome 4.0.249.0
safari 4.0.4
opera 10.01
SA ok, SN ok, SP ignored

firefox 3.0.15
firefox 3.5.5
SA ok, SN ok, SP ok

ie6
ie7
ie8-compat
SA ignored, SN throw "Not implemented", SP throw "Object doesn't support
this action"

ie8-std
SA ok, SN ok, SP throw "Object doesn't support this action"


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[googl...@googlecode.com]

Updates:
Status: Pending

Comment #1 on issue 1171 by felix8a: IE[67] throws when setting type of
buttons
http://code.google.com/p/google-caja/issues/detail?id=1171

http://codereview.appspot.com/159053/show

[googl...@googlecode.com]

Updates:
Status: Fixed

Comment #2 on issue 1171 by felix8a: IE[67] throws when setting type of
buttons
http://code.google.com/p/google-caja/issues/detail?id=1171

@r3866