shorten the top-level var warning (issue 6244054)

2 views
Skip to first unread message

fel...@gmail.com

unread,
May 25, 2012, 12:17:25 AM5/25/12
to jas...@gmail.com, meta...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: Jasvir, metaweta,

Description:
When building caja, one of the warning messages starts

[transform] LINT : css-defs.js:46+1 - 777+7: Top level variable
declarations incompatiable with Caja. Please rewrite as window[
'cssSchema' ] = (function () {

and continues for 730 lines.

There are several messages like this. The one for Domado is 4328 lines.

This change omits the rhs of these warning messages.

Please review this at http://codereview.appspot.com/6244054/

Affected files:
M src/com/google/caja/parser/quasiliteral/ES53Rewriter.java


Index: src/com/google/caja/parser/quasiliteral/ES53Rewriter.java
===================================================================
--- src/com/google/caja/parser/quasiliteral/ES53Rewriter.java (revision
4889)
+++ src/com/google/caja/parser/quasiliteral/ES53Rewriter.java (working copy)
@@ -17,7 +17,6 @@
import static com.google.caja.parser.js.SyntheticNodes.s;

import com.google.caja.lexer.FilePosition;
-import com.google.caja.lexer.TokenConsumer;
import com.google.caja.parser.ParseTreeNode;
import com.google.caja.parser.ParseTreeNodeContainer;
import com.google.caja.parser.js.ArrayConstructor;
@@ -65,14 +64,10 @@
import com.google.caja.parser.js.TryStmt;
import com.google.caja.parser.js.UncajoledModule;
import com.google.caja.parser.js.ValueProperty;
-import com.google.caja.render.Concatenator;
-import com.google.caja.render.JsMinimalPrinter;
-import com.google.caja.render.JsPrettyPrinter;
import com.google.caja.reporting.BuildInfo;
import com.google.caja.reporting.MessageLevel;
import com.google.caja.reporting.MessagePart;
import com.google.caja.reporting.MessageQueue;
-import com.google.caja.reporting.RenderContext;
import com.google.caja.util.Lists;
import com.google.caja.util.Sets;

@@ -1001,9 +996,8 @@
RewriterMessageType.TOP_LEVEL_VAR_INCOMPATIBLE_WITH_CAJA,
node.getFilePosition(),
MessagePart.Factory.valueOf(
- render(QuasiBuilder.substV("window['@v'] = @r",
- "v", v,
- "r", r))));
+ render(QuasiBuilder.substV("window['@v']", "v", v))
+ + " = ..."));
return newExprStmt((Expression) substV(
"v", v,
"r", expand(nymize(r, vname, "var"), scope)));


meta...@gmail.com

unread,
May 25, 2012, 1:05:40 AM5/25/12
to fel...@gmail.com, jas...@gmail.com, google-ca...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reply all
Reply to author
Forward
0 new messages