Code review: Wrong version of swprintf used with VS 7.1 CRT

0 views
Skip to first unread message

Mark Mentovai

unread,
Apr 9, 2007, 2:14:32 PM4/9/07
to Brian Ryner, google-br...@googlegroups.com
Brian-

There's an occasional bug using swprintf from the VS 2005/7.1 CRT
directly, because a version of the function that doesn't accept a
length parameter is available. This patch redefines swprintf to
_snwprintf when using early CRTs, as recommended by Microsoft at
http://msdn2.microsoft.com/en-us/library/ybk95axf(VS.71).aspx .

The patch:

http://code.google.com/p/google-breakpad/issues/detail?id=149
http://code.google.com/p/google-breakpad/issues/attachment?aid=-7655147572534354939&name=breakpad.149.1.patch

Mark

Brian Ryner

unread,
Apr 9, 2007, 2:20:21 PM4/9/07
to Mark Mentovai, google-br...@googlegroups.com
Looks good.
--
-Brian
Reply all
Reply to author
Forward
0 new messages