One small patch for Solaris client code

[Alfred Peng]

Hi Mento,

Here is a trivial patch for the Solaris client code: http://code.google.com/p/google-breakpad/issues/attachment?aid=688666837132746074&name=client-assert.patch . Could you help me review this patch?

I found this out when I tried to integrated the Solaris breakpad library into Firefox. It's a little weird that it compiles well just in the client/solaris/handler directory. stack_ has been removed in the Solaris client code actually.

Thanks & Best Regards,
-Alfred

[Mark Mentovai]

Alfred Peng wrote:
> Here is a trivial patch for the Solaris client code:
> http://code.google.com/p/google-breakpad/issues/attachment?aid=688666837132746074&name=client-assert.patch
> . Could you help me review this patch?

Looks good to me. I'm happy to check it in shortly.

> I found this out when I tried to integrated the Solaris breakpad library
> into Firefox. It's a little weird that it compiles well just in the
> client/solaris/handler directory. stack_ has been removed in the Solaris
> client code actually.

This is because you've got NDEBUG defined in your Makefile, so
assert(anything) is just a no-op. Do you need NDEBUG?

Mark