Code review: processor crashes on some truncated minidumps

1 view
Skip to first unread message

Mark Mentovai

unread,
Apr 4, 2008, 3:50:50 PM4/4/08
to Ted Mielczarek, google-br...@googlegroups.com
Ted, could you take a look at the patch? Issue 222 introduced a crash
that occurs when processing some truncated minidumps.

Thanks,
Mark

breakpad_processor.patch

Ted Mielczarek

unread,
Apr 4, 2008, 4:02:53 PM4/4/08
to Mark Mentovai, google-br...@googlegroups.com
On Fri, Apr 4, 2008 at 3:50 PM, Mark Mentovai <mmen...@gmail.com> wrote:
> Ted, could you take a look at the patch? Issue 222 introduced a crash
> that occurs when processing some truncated minidumps.

Ah, sorry about that. Looks good to me.

Thanks,
-Ted

Ted Mielczarek

unread,
Apr 4, 2008, 4:07:49 PM4/4/08
to Mark Mentovai, google-br...@googlegroups.com
On Fri, Apr 4, 2008 at 3:50 PM, Mark Mentovai <mmen...@gmail.com> wrote:
> Ted, could you take a look at the patch? Issue 222 introduced a crash
> that occurs when processing some truncated minidumps.

FWIW, we should probably add some samples like the dumps that trigger
this (and the minidump from issue 222) to the test suite.

-Ted

Mark Mentovai

unread,
Apr 4, 2008, 5:43:02 PM4/4/08
to Ted Mielczarek, google-br...@googlegroups.com
Ted Mielczarek wrote:
> FWIW, we should probably add some samples like the dumps that trigger
> this (and the minidump from issue 222) to the test suite.

We might even be able to do this by using truncated versions of the
existing "clean" dumps, to avoid checking in "wild" dumps submitted by
users.

Mark

Reply all
Reply to author
Forward
0 new messages