Code review: Allow finer control over installed handler types (#193)

0 views
Skip to first unread message

Mark Mentovai

unread,
Jul 2, 2007, 12:03:44 PM7/2/07
to Ted Mielczarek, google-br...@groups.google.com
Ted, I've got a small-ish patch to make Breakpad use in the SEH world
more practical by allowing SEH invocation to coexist with the invalid
parameter and purecall handlers. I'd appreciate a review.

http://code.google.com/p/google-breakpad/issues/detail?id=193
http://code.google.com/p/google-breakpad/issues/attachment?aid=-8180659738991397652&name=breakpad.193.1.patch

Thanks,
Mark

Ted Mielczarek

unread,
Jul 2, 2007, 3:31:12 PM7/2/07
to Mark Mentovai, google-br...@groups.google.com
Index: src/client/windows/handler/exception_handler.h
+ // is called after writing the dump file, as described above. HandlerType

Should be "handler_types". Other than that tiny nit, my only qualm
with this is that it further skews the ExceptionHandler constructor
between platforms, but I can live with that.

-Ted

Reply all
Reply to author
Forward
0 new messages