Fix for broken build on mac.

1 view
Skip to first unread message

Siya...@gmail.com

unread,
Nov 3, 2010, 4:28:56 PM11/3/10
to ma...@chromium.org, preston....@gmail.com, google-br...@googlegroups.com
Reviewers: Mark Mentovai, Preston Jackson,

Please review this at http://breakpad.appspot.com/221001

Affected files:
M src/tools/mac/crash_report/on_demand_symbol_supplier.mm


Index: src/tools/mac/crash_report/on_demand_symbol_supplier.mm
===================================================================
--- src/tools/mac/crash_report/on_demand_symbol_supplier.mm (revision 722)
+++ src/tools/mac/crash_report/on_demand_symbol_supplier.mm (working copy)
@@ -171,14 +171,13 @@
symbol_file,
&symbol_data_string);
if (result == FOUND) {
- unsigned int size = symbol_data_string.size() + 1;
- *symbol_data = new char[size];
+ *symbol_data = new char[symbol_data_string.size() + 1];
if (*symbol_data == NULL) {
// Should return INTERRUPT on memory allocation failure.
return INTERRUPT;
}
strcpy(*symbol_data, symbol_data_string.c_str());
- memory_buffers_.insert(make_pair(module->code_file(), *symbol_data);
+ memory_buffers_.insert(make_pair(module->code_file(), *symbol_data));
}
return result;
}


Siya...@gmail.com

unread,
Nov 3, 2010, 5:30:37 PM11/3/10
to ma...@chromium.org, preston....@gmail.com, jessicag...@gmail.com, google-br...@googlegroups.com
Mark, would you please build it on mac to verify it's fixed? Thanks

http://breakpad.appspot.com/221001

Mark Mentovai

unread,
Nov 4, 2010, 11:24:40 AM11/4/10
to Siya...@gmail.com, ma...@chromium.org, preston....@gmail.com, jessicag...@gmail.com, google-br...@googlegroups.com
It does build now.

Mark Mentovai

unread,
Nov 8, 2010, 2:47:05 PM11/8/10
to Preston Jackson, Siya...@gmail.com, jessicag...@gmail.com, google-br...@googlegroups.com
Thanks, I’ve committed this fix in r726.
Reply all
Reply to author
Forward
0 new messages