goliath-contrib for interesting-but-not-essential patches?

Skip to first unread message

Philip (flip) Kromer

unread,
Apr 20, 2011, 12:16:01 AM4/20/11
to Goliath Mailing List
I'm loving Goliath -- we plan to put this into production in multiple roles within infochimps.

A few procedurals:

* I don't think it's possible for a non-repo member to edit the mainline wiki... I put up some content at https://github.com/infochimps/goliath/wiki if you'd like to pull from it.

* Just did a pull request for code to do Chunked Transfer Encoded HTTP streaming.

* I have a couple things that might be interesting but are certainly not essential. At your preference and discretion, I'd be glad to publish them into a) postrank-labs/goliath mainline, b) a postrank-labs/goliath_contrib that you set up for "neat but not canonical contribs", or c) infochimps/goliath_chimps for whomever wants it.

Those include:

  1) a YAML formatter 
  2) send static file from /public
  3) brutally simple template rendering from /app/views

On 2 & 3: for a lot of things it's useful to have a little embedded control panel. One wouldn't want to have a half-assed Sinatra sprout up in the Goliath repo, but it is nice to be able to say 'haml :dashboard, {stuff}' and have it render {stuff}.

Anyway, let me know which if any are interesting and where you'd like to put them -- I'll send the appropriate pull requests.


Mando Escamilla

unread,
Apr 20, 2011, 1:37:37 AM4/20/11
to golia...@googlegroups.com
Flip,

You beat me to the punch!  I was planning to write a template renderer for Goliath tomorrow, so I'd *definitely*
like to see that code :). 

--
Mando

Philip (flip) Kromer

unread,
Apr 20, 2011, 2:16:57 AM4/20/11
to golia...@googlegroups.com
Linked to it inline but might not have shown up in your reader --

Here's an ugly but effective menu of endpoints:

flip
--
infochimps.com - discover data

igrigorik

unread,
Apr 20, 2011, 10:38:48 AM4/20/11
to golia...@googlegroups.com
Phil, awesome stuff! To make everyone's life easier.. the wiki should be open to edit now, and you should have commit rights on the project now. Feel free to edit, push and merge.. We have a bunch of people monitoring the commits, so we'll review this stuff as it comes in. :-)

Re, static files: I'd love to see an API for that via the "fast file streamer" built into EM. I believe Dan had a gist around that, which needed a bit more work.. but it would allow us to avoid having to load the entire file into memory.

ig

P.S. Great stuff!

dan sinclair

unread,
Apr 20, 2011, 10:44:02 AM4/20/11
to golia...@googlegroups.com
The fast file streamer stuff is at https://gist.github.com/f4d997c3eeb6bdc5a9f3. It was a bit of a hack to make it work (making the Goliath::Env pretend to be an EM::Connection). But, it did work. So, maybe a good starting point for getting something like this to work (or maybe we need to patch EM to give another way to access fast file streamer?

dan

Reply all
Reply to author
Forward
0 new messages