QWT 6.0.1 Support

[Mark Liversedge]

Damien has worked up QWT 6.0.1 support (including the multi-axis patch).

This will enable us to exploit some of the new v6 features and also brings in some much needed bug fixes, largely related to painting and performance.

Whilst we have both done a bit of testing there may still be bugs, so worth checking ...

... if you are buildng your own binaries you will need to make distclean; qmake and make the entire src and qwt trees.

Big props to Damien for sorting this, its been on the radar for ages and he did the hard yards.

Mark

[Jamie Kimberley]

Thanks much for doing this. I think that we have a few housekeeping
items to take care of.

Any info on the qwtbuild.pri and qwt.pro.user files are for?

I see that the qwtbuild.pri file is in the qwt distribution, but it
doesn't seem to be used by any other files.

qwt.pro.user seems to be a superfluous config file left over. It is
not in the official qwt distribution.

Also we should update qwtconfig.pri.in in our repo to reflect the
updated version of qwt. There are some differences between the
qwtconfig.pri file that is distributed with qwt 6.0.1 and what we
have in the repo as qwtconfig.pri.in

All that said, I was able to build on my mac with no issues. Great
job.

Jamie

> --
> _______________________________________________
> Golden-Cheetah-Users mailing list
> golden-che...@googlegroups.com
> http://groups.google.com/group/golden-cheetah-users?hl=en

"You don't use science to show that you're right, you use science to
become right."--xkcd
__________________
Jamie Kimberley
Postdoctoral Fellow
Department of Mechanical Engineering
The Johns Hopkins University
Office: 410.516.5162
Mobile: 217.621.8272
Fax: 410.516.4316
E-Mail:jamie.k...@jhu.edu

[djconnel]

On the topic of QWT: it seems there's an issue with compiling the code
when there's already a version of QWT in the include path. The
include file for the installed version gets incorporated in lieu of
the one in the GoldenCheetah directory. A resolution would be to
rename the hacked "qwt" to something different. This would further
clarify that the local qwt wasn't actually qwt.

Although perhaps going to QWT6 removes the need for a hacked local
version.

[Jamie Kimberley]

Hi Dan, Thanks for the note.

sadly the multiple axis patch was not included in qwt 6.0.1

To your observation, I'm guessing the build is pulling in the
header files from your other "stock" qwt install. I think that
while we add our modified qwt to the INCLUDEPATH, qmake finds your
system files first. Is a solution to this just more explicitly
hardcoding the include paths to point directly to the header files
in the qwt dir?

Jamie

[Mark Liversedge]

On Sunday, 5 February 2012 20:23:56 UTC, Jamie Kimberley wrote:

Any info on the qwtbuild.pri and qwt.pro.user files are for?

http://qwt.sourceforge.net/qwtinstall.html

Although it mentions qwtbuild.pri you are right, it is not used anywhere. Maybe it has been deprecated, I couldn't find any details of that though.

I think we could probably zap qwt.pro.user, not sure why it is there.

Maybe we should just wipe them and reinstate them if they become required?

Also we should update qwtconfig.pri.in in our repo to reflect the 

updated version of qwt.  There are some differences between the
qwtconfig.pri file that is distributed with qwt 6.0.1 and what we
have in the repo as qwtconfig.pri.in

Oh, are you saying that qwtconfig.pri.in has not been updated to the 6.0.1 version?

That's probably my fault, I mucked about a bit before committing Damien's patch...

[djconnel]

Well, I may have been premature in my diagnosis...

I've gotten super rusty on this stuff.

I downloaded this morning:
git clone git://github.com/srhea/GoldenCheetah.git

Then when I ran make, I got:
CpintPlot.o: In function `CpintPlot::configChanged()':
CpintPlot.cpp:(.text+0x3d9): undefined reference to
`QwtPlot::setCanvasBackground(QColor const&)'
CpintPlot.cpp:(.text+0x417): undefined reference to
`QwtPlotGrid::setPen(QPen const&)'
CpintPlot.o: In function `CpintPlot::CpintPlot(QString, Zones
const*)':
CpintPlot.cpp:(.text+0x594): undefined reference to
`QwtPlot::QwtPlot(QWidget*)'
CpintPlot.cpp:(.text+0x673): undefined reference to
`QwtLegend::QwtLegend(QWidget*)'
CpintPlot.cpp:(.text+0x68b): undefined reference to
`QwtPlot::insertLegend(QwtLegend*, QwtPlot::LegendPosition, double)'
... etc

Is the problem with the code, or my set-up?

thanks,
Dan

[Mark Liversedge]

It looks like the patch was faulty, Damien is working on it and I'm going to be reverting the commit from today as it is incomplete.

Will re-open the feature request too.

I'm just rebuilding/retesting from a revert and will update the main repo before SB46 starts :)

Mark

[Mark Liversedge]

Hi,

Damien has spent all week fixing this and now have a patch that looks good and has been pushed.

IMPORTANT: Any LTM charts will need to be reconfigured since the constants for curve styles have changed in QWT 6 and we decided it was wrong to introduce 'backwards compatibility' for a development release.

Cheers,

Mark

PS: Big thanks for Damien who has done this largely to support showing headwind on the ride plot using a QwtPlotIntervalCurve like the iBike software does. Respect.