code review 9752044: runtime: explicit init of runtime-gdb helpers (issue 9752044)

[a...@google.com]

Reviewers: golang-dev1,

Message:
Hello golan...@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
runtime: explicit init of runtime-gdb helpers

If using other gdb python scripts loaded before Go's gdb-runtime.py
and that have a different init prototype:
Traceback (most recent call last):
File "/usr/lib/go/src/pkg/runtime/runtime-gdb.py", line 446, in
<module>
k()
TypeError: __init__() takes exactly 3 arguments (1 given)

The problem is that gdb keeps all python scripts in the same namespace,
so vars() contains them. To avoid that, load helpers one by one.

Please review this at https://codereview.appspot.com/9752044/

Affected files:
M src/pkg/runtime/runtime-gdb.py


Index: src/pkg/runtime/runtime-gdb.py
===================================================================
--- a/src/pkg/runtime/runtime-gdb.py
+++ b/src/pkg/runtime/runtime-gdb.py
@@ -436,6 +436,9 @@
#
# Register all convenience functions and CLI commands
#
-for k in vars().values():
- if hasattr(k, 'invoke'):
- k()
+GoLenFunc()
+GoCapFunc()
+DTypeFunc()
+GoroutinesCmd()
+GoroutineCmd()
+GoIfaceCmd()

[go...@golang.org]

R=iant (assigned by r)

https://codereview.appspot.com/9752044/