Received: by 10.58.230.229 with SMTP id tb5mr1748627vec.17.1344639907500;
        Fri, 10 Aug 2012 16:05:07 -0700 (PDT)
X-BeenThere: golang-dev@googlegroups.com
Received: by 10.52.98.232 with SMTP id el8ls3713027vdb.7.gmail; Fri, 10 Aug
 2012 16:05:06 -0700 (PDT)
Received: by 10.58.212.198 with SMTP id nm6mr1712378vec.35.1344639906355;
        Fri, 10 Aug 2012 16:05:06 -0700 (PDT)
Received: by 10.58.212.198 with SMTP id nm6mr1712377vec.35.1344639906347;
        Fri, 10 Aug 2012 16:05:06 -0700 (PDT)
Return-Path: <3opMlUA0JCuUJVKLYLcPLd-OYNTHPS.JVTNVSHUN-KLcNVVNSLNYVbWZ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-vb0-f70.google.com (mail-vb0-f70.google.com [209.85.212.70])
        by gmr-mx.google.com with ESMTPS id y20si33862vdd.0.2012.08.10.16.05.06
        (version=TLSv1/SSLv3 cipher=OTHER);
        Fri, 10 Aug 2012 16:05:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3opMlUA0JCuUJVKLYLcPLd-OYNTHPS.JVTNVSHUN-KLcNVVNSLNYVbWZ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.212.70 as permitted sender) client-ip=209.85.212.70;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3opMlUA0JCuUJVKLYLcPLd-OYNTHPS.JVTNVSHUN-KLcNVVNSLNYVbWZ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.212.70 as permitted sender) smtp.mail=3opMlUA0JCuUJVKLYLcPLd-OYNTHPS.JVTNVSHUN-KLcNVVNSLNYVbWZ....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com
Received: by vbzb23 with SMTP id b23so3492736vbz.5
        for <golang-dev@googlegroups.com>; Fri, 10 Aug 2012 16:05:06 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.58.212.198 with SMTP id nm6mr1712373vec.35.1344639906201; Fri,
 10 Aug 2012 16:05:06 -0700 (PDT)
Reply-To: kra...@golang.org, i...@golang.org, imkra...@gmail.com, 
	kra...@google.com, i...@google.com, minux...@gmail.com, r...@golang.org, 
	nigel...@golang.org, golang-dev@googlegroups.com, 
	re...@codereview-hr.appspotmail.com
Message-ID: <047d7bea3b36f5c12404c6f15f30@google.com>
Date: Fri, 10 Aug 2012 23:05:06 +0000
Subject: Re: runtime: add vdso support for linux/amd64. (issue 6454046)
From: i...@golang.org
To: kra...@golang.org, imkra...@gmail.com, kra...@google.com, i...@google.com, 
	minux...@gmail.com, r...@golang.org, nigel...@golang.org
Cc: golang-dev@googlegroups.com, re...@codereview-hr.appspotmail.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

Looking very close.

Have you signed the copyright license agreement mentioned at the bottom
of http://golang.org/doc/contribute.html ?


http://codereview.appspot.com/6454046/diff/23/src/pkg/runtime/vdso_linux_amd64.c
File src/pkg/runtime/vdso_linux_amd64.c (right):

http://codereview.appspot.com/6454046/diff/23/src/pkg/runtime/vdso_linux_amd64.c#newcode316
src/pkg/runtime/vdso_linux_amd64.c:316:
vdso_init_from_sysinfo_ehdr((Elf64_Ehdr*)elf_auxv[i].a_un.a_val);
Will it work to make vdso_info a local variable of this function, and
pass the address go vdso_init_from_sysinfo_ehdr and vdso_parse_symbols?

http://codereview.appspot.com/6454046/diff/23/src/pkg/runtime/vdso_linux_amd64.c#newcode325
src/pkg/runtime/vdso_linux_amd64.c:325: static void linux_sysargs(int32
argc, uint8** argv) {
What is this intermediate function for?

http://codereview.appspot.com/6454046/