Received: by 10.66.77.35 with SMTP id p3mr1060406paw.44.1342926049414;
        Sat, 21 Jul 2012 20:00:49 -0700 (PDT)
X-BeenThere: golang-dev@googlegroups.com
Received: by 10.68.129.226 with SMTP id nz2ls2665729pbb.5.gmail; Sat, 21 Jul
 2012 20:00:48 -0700 (PDT)
Received: by 10.66.77.1 with SMTP id o1mr961811paw.29.1342926048637;
        Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
Received: by 10.66.77.1 with SMTP id o1mr961809paw.29.1342926048628;
        Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
Return-Path: <mikioh.mik...@gmail.com>
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54])
        by gmr-mx.google.com with ESMTPS id oh7si4446449pbb.2.2012.07.21.20.00.48
        (version=TLSv1/SSLv3 cipher=OTHER);
        Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of mikioh.mik...@gmail.com designates 209.85.160.54 as permitted sender) client-ip=209.85.160.54;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mikioh.mik...@gmail.com designates 209.85.160.54 as permitted sender) smtp.mail=mikioh.mik...@gmail.com; dkim=pass header...@gmail.com
Received: by pbbro2 with SMTP id ro2so8030107pbb.41
        for <golang-dev@googlegroups.com>; Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=hHYndpBB0lKk36ukgb14wU/n9meNIcMuuloKXUGZ7vY=;
        b=X1yitf9AW+PFbsu7eJTTN3o74mPMTZVMztbfFfAeJst4PnCFriDVmcLCqMXNzxE/Sy
         nlHz+rMLA1GrPHQC7KKpIhbgWjB0o54HxBBaGIVs4reMteEPVoPkx9zXDRuJlnYN1t9C
         4qrnUyDU+pvQcVzZZnv8azeZswZ9s3e0Np6HTkWoRKJkHefenwpJzD2thmEfMUdItBca
         DVELWau0ogWk85u/pE3X3nHw8mCTgw66KqlJ/J64Fx4l1w0iXGW414C/24ZIxQAkpqRq
         0C9n4tuaIH1/rzWFrqfxdnPgjdXlZrH5xRSq1wMrUUsLis3ZDFG65SommDEmyybHgmsa
         KBkw==
MIME-Version: 1.0
Received: by 10.68.195.202 with SMTP id ig10mr25217907pbc.37.1342926048428;
 Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
Received: by 10.68.24.70 with HTTP; Sat, 21 Jul 2012 20:00:48 -0700 (PDT)
In-Reply-To: <CAHxS-ovfOKv5zf+o3S=mrKJZAmxeF23T64HSyKvQK-u2TdL...@mail.gmail.com>
References: <bcaec5014a37d0dfb904c556f...@google.com>
	<CAHxS-ovfOKv5zf+o3S=mrKJZAmxeF23T64HSyKvQK-u2TdL...@mail.gmail.com>
Date: Sun, 22 Jul 2012 12:00:48 +0900
Message-ID: <CAAh0P7VHMvdHtGMMDEGdQSi4Q1faxYLB08_hg8h7RhPmZ+1...@mail.gmail.com>
Subject: Re: [golang-dev] code review 6431053: net: fix ResolveIPAddr for IPv6
 address enclosed in squ... (issue 6431053)
From: Mikio Hara <mikioh.mik...@gmail.com>
To: Andrew Gerrand <a...@google.com>
Cc: "golang-dev@googlegroups.com" <golang-dev@googlegroups.com>, 
	"re...@codereview-hr.appspotmail.com" <re...@codereview-hr.appspotmail.com>
Content-Type: text/plain; charset=ISO-8859-1

Thank you for the comment. I realized that I put bracket remove lines
in wrong place, that should stay just before ParseIP in hostToIP.

On Sun, Jul 22, 2012 at 9:58 AM, Andrew Gerrand <a...@google.com> wrote:

> Should this be in parseIPv6 instead?

I guess, code itself says IP and IPAddr are different things. IP represents
a plain IP address and IPAddr represents something like IP address literal
in raw IP socket address, something like:

IP = IPv6Address
IPAddr = IPLiteralInRawIPSock ":" Port
IPLiteralInRawIPSock = "[" IPv6address / Name "]"

This looks similar to the relationship btw IPv6 address and literal IPv6
address in URL.

> Is [hostname] valid? Shouldn't ParseIP("[::]") work? Not clear to me that it
> does.

-- Mikio