Received: by 10.180.98.167 with SMTP id ej7mr107426wib.1.1337885444079;
        Thu, 24 May 2012 11:50:44 -0700 (PDT)
X-BeenThere: golang-dev@googlegroups.com
Received: by 10.220.227.74 with SMTP id iz10ls764349vcb.8.gmail; Thu, 24 May
 2012 11:50:43 -0700 (PDT)
Received: by 10.52.29.193 with SMTP id m1mr1389398vdh.4.1337885443192;
        Thu, 24 May 2012 11:50:43 -0700 (PDT)
Received: by 10.52.29.193 with SMTP id m1mr1389396vdh.4.1337885443179;
        Thu, 24 May 2012 11:50:43 -0700 (PDT)
Return-Path: <3A4O-Tw0JCoYmyno1o5so6-r1qwksv.mywqyvkxq-no5qyyqvoq1y4z2....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com>
Received: from mail-vc0-f200.google.com (mail-vc0-f200.google.com [209.85.220.200])
        by gmr-mx.google.com with ESMTPS id l12si65658vdf.3.2012.05.24.11.50.43
        (version=TLSv1/SSLv3 cipher=OTHER);
        Thu, 24 May 2012 11:50:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of 3A4O-Tw0JCoYmyno1o5so6-r1qwksv.mywqyvkxq-no5qyyqvoq1y4z2....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.220.200 as permitted sender) client-ip=209.85.220.200;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of 3A4O-Tw0JCoYmyno1o5so6-r1qwksv.mywqyvkxq-no5qyyqvoq1y4z2....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com designates 209.85.220.200 as permitted sender) smtp.mail=3A4O-Tw0JCoYmyno1o5so6-r1qwksv.mywqyvkxq-no5qyyqvoq1y4z2....@m3kw2wvrgufz5godrsrytgd7.apphosting.bounces.google.com
Received: by vcqp1 with SMTP id p1so145502vcq.11
        for <golang-dev@googlegroups.com>; Thu, 24 May 2012 11:50:43 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.101.137.40 with SMTP id p40mr301243ann.12.1337885443028; Thu,
 24 May 2012 11:50:43 -0700 (PDT)
Reply-To: r...@golang.org, golang-dev@googlegroups.com, r...@golang.org, 
	re...@codereview-hr.appspotmail.com
Message-ID: <0016e68ee23e94f83704c0ccbaa5@google.com>
Date: Thu, 24 May 2012 18:50:43 +0000
Subject: Re: code review 6256048: exp/locale/collate: avoid 16-bit math (issue 6256048)
From: r...@golang.org
To: r...@golang.org
Cc: golang-dev@googlegroups.com, r...@golang.org, 
	re...@codereview-hr.appspotmail.com
Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes

*** Submitted as
http://code.google.com/p/go/source/detail?r=67d925cf4352 ***

exp/locale/collate: avoid 16-bit math

There's no need for the 16-bit arithmetic here,
and it tickles a long-standing compiler bug.
Fix the exp code not to use 16-bit math and
create an explicit test for the compiler bug.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6256048


http://codereview.appspot.com/6256048/