code review 6445068: exp/types: set non-embedded method type during GcImport. (issue 6445068)

[remyoud...@gmail.com]

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
exp/types: set non-embedded method type during GcImport.

Please review this at http://codereview.appspot.com/6445068/

Affected files:
M src/pkg/exp/types/gcimporter.go


Index: src/pkg/exp/types/gcimporter.go
===================================================================
--- a/src/pkg/exp/types/gcimporter.go
+++ b/src/pkg/exp/types/gcimporter.go
@@ -510,11 +510,12 @@
// MethodOrEmbedSpec = Name [ Signature ] .
//
func (p *gcParser) parseMethodOrEmbedSpec() *ast.Object {
- p.parseName()
+ name := p.parseName()
if p.tok == '(' {
- p.parseSignature()
- // TODO(gri) compute method object
- return ast.NewObj(ast.Fun, "_")
+ typ := p.parseSignature()
+ obj := ast.NewObj(ast.Fun, name)
+ obj.Type = typ
+ return obj
}
// TODO lookup name and return that type
return ast.NewObj(ast.Typ, "_")

[g...@golang.org]

LGTM

http://codereview.appspot.com/6445068/

[g...@golang.org]

*** Submitted as
http://code.google.com/p/go/source/detail?r=24e1714dc458 ***

exp/types: set non-embedded method type during GcImport.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/6445068

Committer: Robert Griesemer <g...@golang.org>


http://codereview.appspot.com/6445068/