Received: by 10.180.8.137 with SMTP id r9mr458977wia.2.1335009818153;
        Sat, 21 Apr 2012 05:03:38 -0700 (PDT)
X-BeenThere: golang-dev@googlegroups.com
Received: by 10.180.7.9 with SMTP id f9ls2426246wia.2.canary; Sat, 21 Apr 2012
 05:03:37 -0700 (PDT)
Received: by 10.180.92.170 with SMTP id cn10mr458841wib.3.1335009817154;
        Sat, 21 Apr 2012 05:03:37 -0700 (PDT)
Received: by 10.180.92.170 with SMTP id cn10mr458840wib.3.1335009817145;
        Sat, 21 Apr 2012 05:03:37 -0700 (PDT)
Return-Path: <d...@cheney.net>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
        by gmr-mx.google.com with ESMTPS id dd10si865321wib.0.2012.04.21.05.03.37
        (version=TLSv1/SSLv3 cipher=OTHER);
        Sat, 21 Apr 2012 05:03:37 -0700 (PDT)
Received-SPF: neutral (google.com: 74.125.82.45 is neither permitted nor denied by best guess record for domain of d...@cheney.net) client-ip=74.125.82.45;
Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 74.125.82.45 is neither permitted nor denied by best guess record for domain of d...@cheney.net) smtp.mail=d...@cheney.net
Received: by mail-wg0-f45.google.com with SMTP id dt14so8674444wgb.14
        for <golang-dev@googlegroups.com>; Sat, 21 Apr 2012 05:03:37 -0700 (PDT)
        d=google.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding:x-gm-message-state;
        bh=OYkSH7PeX4kwunbEBhrsf2i/b/V48nF5KKklWq7g3lI=;
        b=DaXwwkx4uUFczFkPeH0Dwl1D1TaqO9ND5yxlx+9oMB1piLR6bnSmpEEoak2P2fi8KZ
         4AHBkJUUBtlkr3cDE8Lc1r5hFO7r/sMUvw65gviZAHGL2Q+PKSODqYi1QIMdldDB1Vot
         Q0OmfdNhjAp5kzncEYvLpQPuCJt23liCD3TmJq6OhAnV98n6gIP+9NLqArmsiTo+8kq9
         qmZeMwWVs3UxQ3FTW7btP3XE0dlhP9SC67Z4wOrfmpkN8+rUmjAGN5JS3w2Z3KYZLD2U
         Za26Rg8bkN1ta5r8eUgmpZ21BIEud21nB3VAycnSOzyQItFw79XfJEMRv7X9se7OIWg1
         fhPg==
MIME-Version: 1.0
Received: by 10.180.103.35 with SMTP id ft3mr5767576wib.0.1335009817048; Sat,
 21 Apr 2012 05:03:37 -0700 (PDT)
Received: by 10.223.21.146 with HTTP; Sat, 21 Apr 2012 05:03:37 -0700 (PDT)
In-Reply-To: <001636ed74fa03e74904be2f2...@google.com>
References: <001636ed74fa03e74904be2f2...@google.com>
Date: Sat, 21 Apr 2012 22:03:37 +1000
Message-ID: <CANp9fE-c12BxYG_gQR1mzJ8R+eNtMf3u6oLn4faJ2r14oai...@mail.gmail.com>
Subject: Re: [golang-dev] code review 6097044: net: fix typo in
 Listener.File() documentation (issue 6097044)
From: Dave Cheney <d...@cheney.net>
To: remyoudomph...@gmail.com, golang-dev@googlegroups.com, r...@archlinux.org, 
	re...@codereview-hr.appspotmail.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: ALoCoQmU6aadiEZVNQq2yminON3/s3w6ONaYcXIt+X0H4XWTDlq0CQTE3UwEOB2qK0R4PVr0/Qam

LGTM.

On Sat, Apr 21, 2012 at 10:01 PM,  <remyoudomph...@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
> r...@archlinux.org),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: fix typo in Listener.File() documentation
>
> Please review this at http://codereview.appspot.com/6097044/
>
> Affected files:
> =A0M src/pkg/net/tcpsock_posix.go
> =A0M src/pkg/net/unixsock_posix.go
>
>
> Index: src/pkg/net/tcpsock_posix.go
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- a/src/pkg/net/tcpsock_posix.go
> +++ b/src/pkg/net/tcpsock_posix.go
> @@ -357,5 +357,5 @@
>
> =A0// File returns a copy of the underlying os.File, set to blocking mode=
.
> =A0// It is the caller's responsibility to close f when finished.
> -// Closing c does not affect f, and closing f does not affect c.
> +// Closing l does not affect f, and closing f does not affect l.
> =A0func (l *TCPListener) File() (f *os.File, err error) { return l.fd.dup=
() }
> Index: src/pkg/net/unixsock_posix.go
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- a/src/pkg/net/unixsock_posix.go
> +++ b/src/pkg/net/unixsock_posix.go
> @@ -404,7 +404,7 @@
>
> =A0// File returns a copy of the underlying os.File, set to blocking mode=
.
> =A0// It is the caller's responsibility to close f when finished.
> -// Closing c does not affect f, and closing f does not affect c.
> +// Closing l does not affect f, and closing f does not affect l.
> =A0func (l *UnixListener) File() (f *os.File, err error) { return l.fd.du=
p() }
>
> =A0// ListenUnixgram listens for incoming Unix datagram packets addressed=
 to
> the
>
>