code review 6097044: net: fix typo in Listener.File() documentation (issue 6097044)

23 views
Skip to first unread message

remyoud...@gmail.com

unread,
Apr 21, 2012, 8:01:24 AM4/21/12
to golan...@googlegroups.com, golan...@googlegroups.com, re...@archlinux.org, re...@codereview-hr.appspotmail.com
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golan...@googlegroups.com (cc: golan...@googlegroups.com,
re...@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
net: fix typo in Listener.File() documentation

Please review this at http://codereview.appspot.com/6097044/

Affected files:
M src/pkg/net/tcpsock_posix.go
M src/pkg/net/unixsock_posix.go


Index: src/pkg/net/tcpsock_posix.go
===================================================================
--- a/src/pkg/net/tcpsock_posix.go
+++ b/src/pkg/net/tcpsock_posix.go
@@ -357,5 +357,5 @@

// File returns a copy of the underlying os.File, set to blocking mode.
// It is the caller's responsibility to close f when finished.
-// Closing c does not affect f, and closing f does not affect c.
+// Closing l does not affect f, and closing f does not affect l.
func (l *TCPListener) File() (f *os.File, err error) { return l.fd.dup() }
Index: src/pkg/net/unixsock_posix.go
===================================================================
--- a/src/pkg/net/unixsock_posix.go
+++ b/src/pkg/net/unixsock_posix.go
@@ -404,7 +404,7 @@

// File returns a copy of the underlying os.File, set to blocking mode.
// It is the caller's responsibility to close f when finished.
-// Closing c does not affect f, and closing f does not affect c.
+// Closing l does not affect f, and closing f does not affect l.
func (l *UnixListener) File() (f *os.File, err error) { return l.fd.dup() }

// ListenUnixgram listens for incoming Unix datagram packets addressed to
the


Dave Cheney

unread,
Apr 21, 2012, 8:03:37 AM4/21/12
to remyoud...@gmail.com, golan...@googlegroups.com, re...@archlinux.org, re...@codereview-hr.appspotmail.com
LGTM.

Russ Cox

unread,
Apr 23, 2012, 9:59:15 AM4/23/12
to Dave Cheney, remyoud...@gmail.com, golan...@googlegroups.com, re...@archlinux.org, re...@codereview-hr.appspotmail.com
LGTM

remyoud...@gmail.com

unread,
Apr 23, 2012, 7:27:41 PM4/23/12
to remyoud...@gmail.com, golan...@googlegroups.com, da...@cheney.net, r...@golang.org, re...@archlinux.org, re...@codereview-hr.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=0739e30d5df7 ***

net: fix typo in Listener.File() documentation

R=golang-dev, dave, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6097044


http://codereview.appspot.com/6097044/

Reply all
Reply to author
Forward
0 new messages