code review 224062: strings: delete Runes, Bytes (issue224062)

3 views
Skip to first unread message

r...@golang.org

unread,
Feb 25, 2010, 6:49:56 PM2/25/10
to r...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
Reviewers: r,

Message:
Hello r (cc: golan...@googlegroups.com),

I'd like you to review this change.


Description:
strings: delete Runes, Bytes

gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports

Please review this at http://codereview.appspot.com/224062/show

Affected files:
M src/cmd/cgo/gcc.go
M src/cmd/ebnflint/ebnflint.go
M src/cmd/godoc/godoc.go
M src/cmd/godoc/index.go
M src/cmd/godoc/snippet.go
M src/cmd/godoc/spec.go
M src/pkg/archive/tar/reader_test.go
M src/pkg/archive/tar/writer.go
M src/pkg/asn1/asn1_test.go
M src/pkg/asn1/marshal.go
M src/pkg/bufio/bufio_test.go
M src/pkg/bytes/bytes_test.go
M src/pkg/compress/gzip/gzip_test.go
M src/pkg/crypto/hmac/hmac_test.go
M src/pkg/crypto/rsa/pkcs1v15_test.go
M src/pkg/crypto/tls/handshake_messages.go
M src/pkg/crypto/tls/prf.go
M src/pkg/crypto/x509/x509.go
M src/pkg/crypto/x509/x509_test.go
M src/pkg/ebnf/ebnf_test.go
M src/pkg/encoding/ascii85/ascii85_test.go
M src/pkg/encoding/base64/base64_test.go
M src/pkg/encoding/git85/git_test.go
M src/pkg/encoding/hex/hex.go
M src/pkg/encoding/pem/pem.go
M src/pkg/encoding/pem/pem_test.go
M src/pkg/exp/datafmt/datafmt_test.go
M src/pkg/exp/datafmt/parser.go
M src/pkg/exp/spacewar/spacewar.go
M src/pkg/fmt/fmt_test.go
M src/pkg/go/doc/comment.go
M src/pkg/go/parser/interface.go
M src/pkg/go/printer/nodes.go
M src/pkg/go/printer/printer.go
M src/pkg/go/scanner/scanner_test.go
M src/pkg/gob/codec_test.go
M src/pkg/http/client.go
M src/pkg/http/lex.go
M src/pkg/http/request.go
M src/pkg/http/url.go
M src/pkg/io/io.go
M src/pkg/io/ioutil/ioutil_test.go
M src/pkg/io/pipe_test.go
M src/pkg/net/dialgoogle_test.go
M src/pkg/net/server_test.go
M src/pkg/os/os_test.go
M src/pkg/patch/patch_test.go
M src/pkg/path/path.go
M src/pkg/regexp/all_test.go
M src/pkg/strings/strings.go
M src/pkg/strings/strings_test.go
M src/pkg/template/format.go
M src/pkg/template/template.go
M src/pkg/template/template_test.go
M src/pkg/testing/regexp_test.go
M src/pkg/utf8/utf8_test.go
M src/pkg/websocket/websocket_test.go
M src/pkg/xgb/xgb.go
M src/pkg/xml/xml.go
M src/pkg/xml/xml_test.go
M test/bench/chameneosredux.go
M test/bench/fasta.go
M test/bench/k-nucleotide.go
M test/bench/meteor-contest.go
M test/bench/regex-dna.go


Rob 'Commander' Pike

unread,
Feb 25, 2010, 6:58:42 PM2/25/10
to r...@golang.org, r...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
LGTM

r...@golang.org

unread,
Feb 25, 2010, 7:01:32 PM2/25/10
to r...@golang.org, r...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
*** Submitted as
http://code.google.com/p/go/source/detail?r=1a4159c225da ***

strings: delete Runes, Bytes

gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports

R=r
CC=golang-dev
http://codereview.appspot.com/224062


http://codereview.appspot.com/224062/show

Reply all
Reply to author
Forward
0 new messages