Re: code review 3458041: io/ioutil: give ReadDir a sorting function (issue3458041)

111 views
Skip to first unread message

al...@pbrane.org

unread,
Dec 15, 2010, 3:45:26 AM12/15/10
to g...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
Hello gri (cc: golan...@googlegroups.com),

Please take another look.


http://codereview.appspot.com/3458041/

r...@google.com

unread,
Dec 15, 2010, 9:13:50 AM12/15/10
to al...@pbrane.org, g...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
I'm still unhappy with adding arguments to ReadDir.
In the very few cases where you need to sort differently,
why not just let the caller re-sort?

Russ


http://codereview.appspot.com/3458041/

Anthony Martin

unread,
Dec 15, 2010, 1:02:32 PM12/15/10
to r...@google.com, g...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
r...@google.com once said:
> I'm still unhappy with adding arguments to ReadDir.
> In the very few cases where you need to sort differently,
> why not just let the caller re-sort?
>
> Russ

I sent this just in case gri wanted to see the change
he requested. I'll abandon it now.

Thanks,
Anthony

al...@pbrane.org

unread,
Dec 15, 2010, 1:08:01 PM12/15/10
to g...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
*** Abandoned ***

http://codereview.appspot.com/3458041/

Reply all
Reply to author
Forward
0 new messages