Re: code review 7002049: runtime: earlier detection of unused spans. (issue 7002049)

[sebastien...@gmail.com]

Gentle ping.

https://codereview.appspot.com/7002049/

[r...@golang.org]

LGTM

Looks good. Please hg sync + hg mail again once atom's current patch is
submitted (it will change mgc0.c).


https://codereview.appspot.com/7002049/

[Russ Cox]

The patch applied cleanly after all. Submitting.

[sebastien...@gmail.com]

On 2013/01/18 22:39:27, rsc wrote:
> The patch applied cleanly after all. Submitting.

Hello Russ,

Manually deleted on my side (`hg -D'), but I'm realising that my
(synced) repo is still not cleaned from the CL.

Are you sure it has actually been submitted?

Thanks,
Sebastien

https://codereview.appspot.com/7002049/

[minu...@gmail.com]

On 2013/01/26 18:47:26, Sebastien Paolacci wrote:
> Manually deleted on my side (`hg -D'), but I'm realising that my
(synced) repo
> is still not cleaned from the CL.

this CL is not submitted yet, please don't close or delete this CL.

however, you do need to do "hg upload" again as mgc0.c has
got some changes.

https://codereview.appspot.com/7002049/

[Russ Cox]

The patched-in CL was sitting in my client. Submitting now for sure!

[r...@golang.org]

*** Submitted as
https://code.google.com/p/go/source/detail?r=57ada05cb325 ***

runtime: earlier detection of unused spans.

Mark candidate spans one GC pass earlier.

Move scavenger's code out from mgc0 and constrain it into mheap (where
it belongs).

R=rsc, dvyukov, minux.ma
CC=golang-dev
https://codereview.appspot.com/7002049

Committer: Russ Cox <r...@golang.org>


https://codereview.appspot.com/7002049/

[Sébastien Paolacci]

Thanks