bytes.Buffer: add Seek, WriteAt, ReadAt, Close, and Closed (issue1939044)

63 views
Skip to first unread message

r...@google.com

unread,
Aug 26, 2010, 11:16:41 AM8/26/10
to byt...@gmail.com, r...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
Saw this in the list. Maybe you're not ready for review
but I want to comment on where this is heading.
It looks like you copied someone else's code, and we
objected to that very same code the first time.
http://codereview.appspot.com/179074

(If you're not ready for comments, please don't set the
Reviewer: or CC: fields when creating the change, and
then we won't see it.)


http://codereview.appspot.com/1939044/

Scott Lawrence

unread,
Aug 26, 2010, 11:27:04 AM8/26/10
to byt...@gmail.com, r...@golang.org, golan...@googlegroups.com, re...@codereview.appspotmail.com
On 8/26/10, r...@google.com <r...@google.com> wrote:
> Saw this in the list. Maybe you're not ready for review
> but I want to comment on where this is heading.
> It looks like you copied someone else's code, and we
> objected to that very same code the first time.
> http://codereview.appspot.com/179074
I did not see that - I was lifting code from the patch provided on the
issue tracker. Thanks for the pointer. (It looks like most of the
objectionable parts have already been left out, and the only remaining
problem is: does this belong in bytes.Buffer at all?)

> (If you're not ready for comments, please don't set the
> Reviewer: or CC: fields when creating the change, and
> then we won't see it.)

Ok.


--
Scott Lawrence

Russ Cox

unread,
Aug 26, 2010, 11:30:14 AM8/26/10
to Scott Lawrence, golan...@googlegroups.com, re...@codereview.appspotmail.com
> I did not see that - I was lifting code from the patch provided on the
> issue tracker. Thanks for the pointer. (It looks like most of the
> objectionable parts have already been left out, and the only remaining
> problem is: does this belong in bytes.Buffer at all?)

It does not. See the comment about Seek.

Reply all
Reply to author
Forward
0 new messages